Attention is currently required from: Felix Held, Martin L Roth, Varshit Pandya.
Hello Martin L Roth, Varshit Pandya,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82262?usp=email
to look at the new patch set (#2).
Change subject: vc/amd/opensil: introduce common mpio/chip.h header file ......................................................................
vc/amd/opensil: introduce common mpio/chip.h header file
The chip drivers in the devicetree use the path where the corresponding chip.h file resides both to include this chip.h file in the static.c generated by util/sconfig from the devicetree and also for the names of the chip config and chip ops struct. To be able to build a SoC using either the MPIO chip driver from the openSIL stub or from the actual openSIL glue code without needing different devicetree files for the different cases, introduce a common MPIO chip.h file that then includes the correct MPIO header file. The chip config and ops structures also need to be renamed to take this change into account.
Thanks to Matt for pointing out how to make the path to the actual MPIO chip.h file configurable via a Kconfig setting. This allows overriding this path from site-local without the need to have any reference to site-local in the upstream code.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iead97d1727569ec0d23a2b9c4fd96daff4bebcf6 --- M src/mainboard/amd/onyx_poc/devicetree.cb M src/soc/amd/genoa_poc/chipset.cb M src/vendorcode/amd/opensil/Kconfig M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h A src/vendorcode/amd/opensil/mpio/chip.h M src/vendorcode/amd/opensil/stub/mpio/chip.c M src/vendorcode/amd/opensil/stub/mpio/chip.h 8 files changed, 115 insertions(+), 98 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/82262/2