Attention is currently required from: Eran Mitrani, Kapil Porwal, Matt DeVillier, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email )
Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS2:
why use ASL here vs runtime-generated AML, like i2c touchscreens do?
creating runtime SSDT for Elan-SPI requires more time to complete the exact ACPI source code, plus we are still evolving around the requirement.
The plan is to enable the HID-SPI using ASL and the migrate to the runtime ASL. By then we can retire this static ASL implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74885?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0
Gerrit-Change-Number: 74885
Gerrit-PatchSet: 10
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Sun, 04 Jun 2023 09:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment