Change in em100[master]: Fix dependencies

List overview All Threads
Download

newer

older

Change in em100[master]: curl:...

Change in em100[master]: WIP: Add...

Stefan Reinauer (Code Review)

5 Dec 2019 5 Dec '19

7:40 p.m.

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37535 )

Change subject: Fix dependencies ......................................................................

Fix dependencies

Jenkins won't let us do perl -pi -e, so let's not do in-place replacement.

Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M Makefile 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/35/37535/1

diff --git a/Makefile b/Makefile index 93a2474..fd1be91 100644 --- a/Makefile +++ b/Makefile @@ -54,8 +54,9 @@ $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $<

dep: $(SOURCES) - $(CC) $(CFLAGS) -MM $(SOURCES) > .dependencies - #perl -pi -e 's,^xz,xz/xz,g' .dependencies + $(CC) $(CFLAGS) -MM $(SOURCES) > .dependencies.tmp + sed 's,^xz,xz/xz,g' .dependencies.tmp > .dependencies + rm .dependencies.tmp

tarballs: makedpfw makechips.sh printf " CREATE config & firmware images\n"

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Patrick Georgi (Code Review)

5 Dec 5 Dec

7:43 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37535 )

Change subject: Fix dependencies ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/em100/+/37535/1/Makefile File Makefile:

https://review.coreboot.org/c/em100/+/37535/1/Makefile@58 PS1, Line 58: sed 's,^xz,xz/xz,g' .dependencies.tmp > .dependencies use sed -i here ("in place"), then mv .dependencies.tmp .dependencies to update atomically.

-- To view, visit https://review.coreboot.org/c/em100/+/37535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Dec 2019 19:43:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

6 Dec 6 Dec

6:53 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37535

to look at the new patch set (#2).

Change subject: Fix dependencies ......................................................................

Fix dependencies

Jenkins won't let us do perl -pi -e, so let's not do in-place replacement.

Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M Makefile 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/35/37535/2

-- To view, visit https://review.coreboot.org/c/em100/+/37535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

6:54 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37535 )

Change subject: Fix dependencies ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/em100/+/37535/1/Makefile File Makefile:

https://review.coreboot.org/c/em100/+/37535/1/Makefile@58 PS1, Line 58: sed 's,^xz,xz/xz,g' .dependencies.tmp > .dependencies

...

use sed -i here ("in place"), then mv .dependencies.tmp .dependencies to update atomically.

Done

-- To view, visit https://review.coreboot.org/c/em100/+/37535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Dec 2019 18:54:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:55 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37535 )

Change subject: Fix dependencies ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/em100/+/37535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Dec 2019 18:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

7:09 p.m.

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37535 )

Change subject: Fix dependencies ......................................................................

Fix dependencies

Jenkins won't let us do perl -pi -e, so let's not do in-place replacement.

Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/37535 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/Makefile b/Makefile index 93a2474..a5b8c33 100644 --- a/Makefile +++ b/Makefile @@ -54,8 +54,9 @@ $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $<

dep: $(SOURCES) - $(CC) $(CFLAGS) -MM $(SOURCES) > .dependencies - #perl -pi -e 's,^xz,xz/xz,g' .dependencies + $(CC) $(CFLAGS) -MM $(SOURCES) > .dependencies.tmp + sed -i 's,^xz,xz/xz,g' .dependencies.tmp + mv .dependencies.tmp .dependencies

tarballs: makedpfw makechips.sh printf " CREATE config & firmware images\n"

-- To view, visit https://review.coreboot.org/c/em100/+/37535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I74d93713cb97bd2b2c415234710fd2b34f6a1c02 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1818

days inactive

1819

days old

coreboot-gerrit@coreboot.org

5 comments

2 participants

tags (0)

participants (2)

Patrick Georgi (Code Review)
Stefan Reinauer (Code Review)