Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
mb/prodrive/hermes: Add multifunction device for UART2
Multifunction device at 19.0 needs to be enabled such that 19.2 gets scanned.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/43481/1
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index 6c6fe2d..48ab0fe 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -177,7 +177,8 @@ device pci 14.3 on end # CNVi wifi end
- device pci 19.2 on end # UART #2 + device pci 19.0 hidden end + device pci 19.2 on end # UART #2
device pci 1b.4 on smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... PS1, Line 180: device pci 19.0 hidden end Any clues as to which device this is? I'd add a comment for the sake of completeness
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... PS1, Line 180: device pci 19.0 hidden end
Any clues as to which device this is? I'd add a comment for the sake of completeness
It doesn't have any function on PCH-H. Maybe add a comment the only reason to have it here is to make the PCI resource allocator aware of 19.2.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... PS1, Line 181: device pci 19.2 on end # UART #2 19.2 should be marked hidden as well, as it cannot be detected using the regular PCI mechanism.
Angel Pons has uploaded a new patch set (#2) to the change originally created by Christian Walter. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
mb/prodrive/hermes: Add multifunction device for UART2
Multifunction device at 19.0 needs to be enabled such that 19.2 gets scanned.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/43481/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART2 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... PS1, Line 180: device pci 19.0 hidden end
It doesn't have any function on PCH-H. […]
Done
https://review.coreboot.org/c/coreboot/+/43481/1/src/mainboard/prodrive/herm... PS1, Line 181: device pci 19.2 on end # UART #2
19.2 should be marked hidden as well, as it cannot be detected using the regular PCI mechanism.
Done
Angel Pons has uploaded a new patch set (#3) to the change originally created by Christian Walter. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART 2 ......................................................................
mb/prodrive/hermes: Add multifunction device for UART 2
On CNP-H, only four I2C controllers are available, so PCI devices 19.0 and 19.1 are missing. However, PCI device 19.2 still exists as UART 2.
That function 0 is missing means UART 2 can only be used in ACPI mode. Both devices need to be marked as hidden on the devicetree so that the allocator takes UART 2 into account.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4 Signed-off-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/43481/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART 2 ......................................................................
Patch Set 3: Code-Review+2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43481 )
Change subject: mb/prodrive/hermes: Add multifunction device for UART 2 ......................................................................
mb/prodrive/hermes: Add multifunction device for UART 2
On CNP-H, only four I2C controllers are available, so PCI devices 19.0 and 19.1 are missing. However, PCI device 19.2 still exists as UART 2.
That function 0 is missing means UART 2 can only be used in ACPI mode. Both devices need to be marked as hidden on the devicetree so that the allocator takes UART 2 into account.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4 Signed-off-by: Christian Walter christian.walter@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43481 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index b3649f9..d1694dc 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -173,7 +173,10 @@ device pci 14.3 on end # CNVi wifi end
- device pci 19.2 on end # UART #2 + # This device does not have any function on CNP-H, but it needs + # to be here so that the resource allocator is aware of UART 2. + device pci 19.0 hidden end + device pci 19.2 hidden end # UART #2, in ACPI mode
device pci 1b.4 on smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Patrick Rudolph (Code Review)