Patrick Rudolph submitted this change.
mb/prodrive/hermes: Add multifunction device for UART 2
On CNP-H, only four I2C controllers are available, so PCI devices 19.0
and 19.1 are missing. However, PCI device 19.2 still exists as UART 2.
That function 0 is missing means UART 2 can only be used in ACPI mode.
Both devices need to be marked as hidden on the devicetree so that the
allocator takes UART 2 into account.
Change-Id: Ie77198cc0327414b9f88cf15ba4efaddb4f5cca4
Signed-off-by: Christian Walter <christian.walter@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43481
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
---
M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
index b3649f9..d1694dc 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb
@@ -173,7 +173,10 @@
device pci 14.3 on end # CNVi wifi
end
- device pci 19.2 on end # UART #2
+ # This device does not have any function on CNP-H, but it needs
+ # to be here so that the resource allocator is aware of UART 2.
+ device pci 19.0 hidden end
+ device pci 19.2 hidden end # UART #2, in ACPI mode
device pci 1b.4 on
smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthOther" "SLOT1" "SlotDataBusWidth4X"
To view, visit change 43481. To unsubscribe, or for help writing mail filters, visit settings.