Change in coreboot[master]: lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test

[Patrick Georgi (Code Review)]

Attention is currently required from: Nico Huber, Martin Roth, Julius Werner, Felix Held.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51838 )

Change subject: lint: checkpatch: Add SUSPICIOUS_CODE_INDENT test
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> If it does the same job just as well, I'm happy with that solution too. […]

Because, like your approach, it's a heuristic, and one that extends the "implied" grammar of the language we choose with a whitespace context element. Heuristics have the annoying habit of falsely triggering every now and then.

There are some folks who'd rather move away from making whitespace count like that. See: golang and rust, the two newest somewhat-popular kids on the curly-braces language block, both abolishing this concept from their grammars _completely_.