Attention is currently required from: Dolan Liu, Eric Lai, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ......................................................................
Patch Set 4:
(5 comments)
File src/drivers/i2c/rt5645/chip.h:
https://review.coreboot.org/c/coreboot/+/81773/comment/8eb474ab_20907869 : PS2, Line 7: const char *name; /* ACPI _HID */
`acpi name` in comments
Done
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/c2d0dae7_d9c237be : PS2, Line 59: acpigen_write_name_string("_DDN", dev->chip_ops->name);
better to use the `config->desc` if defined
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/15e7d879_4129b913 : PS2, Line 100: printk(BIOS_INFO, "%s: %s\n", path, dev->chip_ops->name);
if chip_ops->name change to `&config->desc`, this should be changed to the same
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/3d8c5ee7_a3c5760a : PS2, Line 110: snprintf(name, sizeof(name), "D%03.3X", dev->chip_ops->name);
better to print `dev->path.i2c. […]
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/5ccda419_c4582d45 : PS2, Line 112: //return RT5645_ACPI_NAME;
remove this
Done