[M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message - coreboot-gerrit

4 Jan 2023


      Attention is currently required from: Subrata Banik.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 )
Change subject: drivers/pc80/vga: Add API to write multi-line video message
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/pc80/vga/vga.c:
https://review.coreboot.org/c/coreboot/+/71265/comment/140ab0e5_d78079cd 
PS8, Line 268: 	for (i = 0; i < (VGA_COLUMNS - offset); i++) {
What about potential exiting characters in the margin ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/71265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b
Gerrit-Change-Number: 71265
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Compostella jeremy.compostella@gmail.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 02:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment