Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62943 )
Change subject: soc/intel/alderlake: Allow retrieving FSP timestamp information
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/62943/comment/a8a2f9af_0cf15a34
PS5, Line 39: DISPLAY_FSP_TIMESTAMPS
I kinda think this should be mainboard specific, as not necessarily all users of an SoC will have this PCD enabled
Yes, I will be marking this WIP as I don't want to enable this by default and let user select this when they are debugging
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I568f18c6bc4f54e87f8763a331796f4a72d4c976
Gerrit-Change-Number: 62943
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 16:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment