Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28644 )
Change subject: mb/lenovo/r500: Add mainboard ......................................................................
Patch Set 9:
(1 comment)
Patch Set 8: Code-Review+1
(1 comment)
The VBT wasn't added for other variants yet, as there are too different panels. What's the state on R500?
This one works fine for r500. I'll try to find the other ones.
https://review.coreboot.org/#/c/28644/8/src/mainboard/lenovo/t400/variants/t... File src/mainboard/lenovo/t400/variants/t400/overridetree.cb:
https://review.coreboot.org/#/c/28644/8/src/mainboard/lenovo/t400/variants/t... PS8, Line 6: chip drivers/lenovo/hybrid_graphics
why is there no hybridge graphics enabled on R500. Some models ship with an ATI GPU.
I think there only one or the other can be used, looking at the schematics. Now that I compare the schematics of the discrete model vs integrated model, there is a difference in gpio21 (ground vs vcc3b). I'll use that to fill in sysinfo->enable_igd and sysinfo->enable_peg
-
Arthur Heymans (Code Review)