Attention is currently required from: Arthur Heymans, Michael Büchler.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73087 )
Change subject: mb/intel/dq67sw: Add a new mainboard ......................................................................
Patch Set 4: Code-Review+1
(14 comments)
File Documentation/mainboard/intel/dq67sw.md:
https://review.coreboot.org/c/coreboot/+/73087/comment/fcdb29fe_6eb80178 PS4, Line 31: - Sandy Bridge CPUs (tested: i5-2500) Were Ivy Bridge CPUs tested?
https://review.coreboot.org/c/coreboot/+/73087/comment/90695a01_bfeb6d85 PS4, Line 55: - Booting Windows 10 from SeaBIOS + libgfxinit What happens? Windows 10 can boot on the P8Z77-V LX2 with libgfxinit + VBT + edk2
https://review.coreboot.org/c/coreboot/+/73087/comment/adeb069f_84d86f76 PS4, Line 62: Other audio jacks than the green one Audio jacks other than the green one
https://review.coreboot.org/c/coreboot/+/73087/comment/3bf45f31_c1ae5d68 PS4, Line 135: Currently there is no automatic, OS-independent fan control. One can still use OS-based fan control programs, such as fancontrol on Linux or SpeedFan on Windows.
File src/mainboard/intel/dq67sw/Kconfig:
https://review.coreboot.org/c/coreboot/+/73087/comment/56cf3f30_6b523179 PS4, Line 27: config DRAM_RESET_GATE_GPIO : int : default 60 Default, can br dropped
File src/mainboard/intel/dq67sw/board_info.txt:
https://review.coreboot.org/c/coreboot/+/73087/comment/7d65eaef_3c1a4908 PS4, Line 4: FIXME: check category, , put ROM package, ROM socketed, Release year FIXME
File src/mainboard/intel/dq67sw/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73087/comment/a162c2c7_310d9b75 PS2, Line 14: register "gen2_dec" = "0x000c02a1"
The line is from autoport and this is how the vendor fw sets up this register. […]
If there's nothing on LPC that's using this range, then you should drop it
File src/mainboard/intel/dq67sw/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73087/comment/d92416fd_31d9ba09 PS4, Line 5: Host bridge Host bridge One "Host bridge" is enough
https://review.coreboot.org/c/coreboot/+/73087/comment/b363f700_a2ca1e20 PS4, Line 6: subsystemid 0x8086 0x2008 Inherit the subsystemid?
``` device domain 0 on subsystemid 0x8086 0x2008 inherit device ref host_bridge on end # Host bridge device ref peg10 on end # PEG device ref igd on end # iGPU ```
The iGPU would also get the subsystemid, but it should be fine
https://review.coreboot.org/c/coreboot/+/73087/comment/74485d88_5a7e0ec6 PS4, Line 15: register "pcie_port_coalesce" = "1" If PCIe root port 1 is enabled, coalescing isn't needed.
https://review.coreboot.org/c/coreboot/+/73087/comment/dd8db14d_354f47d8 PS4, Line 23: device ref mei2 off end # Management Engine Interface 2 If this is off in the chipset devicetree, please drop it from the mainboard devicetree
File src/mainboard/intel/dq67sw/early_init.c:
https://review.coreboot.org/c/coreboot/+/73087/comment/73992520_c800fcb9 PS4, Line 3: nit: double blank line
https://review.coreboot.org/c/coreboot/+/73087/comment/8d0267a9_30516e41 PS4, Line 32: FIXME FIXME
File src/mainboard/intel/dq67sw/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/73087/comment/627ae7e1_8e803d16 PS4, Line 1: only Mind licensing this as GPL-2.0-or-later for consistency with other gma-mainboard.ads files?
-
Angel Pons (Code Review)