Change in ...coreboot[master]: nb/amd/amdfam10/northbridge.c: Remove variable set but not used

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

25 May 2019 25 May '19

11:33 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33013

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/1

diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 1d071c1..db40267 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -1690,7 +1690,6 @@

uint8_t fam15h = 0; uint8_t rev_gte_d = 0; - unsigned nb_cfg_54; uint32_t family; uint32_t model;

@@ -1700,7 +1699,6 @@ if (is_fam15h()) { /* Family 15h or later */ fam15h = 1; - nb_cfg_54 = 1; }

if ((model >= 0x8) || fam15h) @@ -1862,7 +1860,6 @@ uint8_t compute_unit_count = 0;

uint32_t f3xe8; - uint8_t dual_node = 0;

for (i = 0; i < sysconf.nodes; i++) { struct device *f3x_dev = pcidev_on_root(0x18 + i, 3); @@ -1871,10 +1868,6 @@

f3xe8 = pci_read_config32(f3x_dev, 0xe8);

- /* Check for dual node capability */ - if (f3xe8 & 0x20000000) - dual_node = 1; - /* Determine the number of active compute units on this node */ f5x80 = pci_read_config32(f5x_dev, 0x80); cu_enabled = f5x80 & 0xf;

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Marshall Dawson (Code Review)

27 May 27 May

8:37 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 27 May 2019 15:37:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

28 May 28 May

11:29 p.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#3).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 1 insertion(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

29 May 29 May

3:57 a.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#4).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 1 insertion(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:57 a.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#5).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 1 insertion(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

3 Jun 3 Jun

6:33 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33013/5/src/northbridge/amd/amdfam10/northbr... File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/33013/5/src/northbridge/amd/amdfam10/northbr... PS5, Line 1585: don't we want to keep the assignment to "model"?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 03 Jun 2019 13:33:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:02 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33013/5/src/northbridge/amd/amdfam10/northbr... File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/33013/5/src/northbridge/amd/amdfam10/northbr... PS5, Line 1585:

...

don't we want to keep the assignment to "model"?

Oops. thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 03 Jun 2019 17:02:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:06 a.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#6).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 2 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Marshall Dawson (Code Review)

4 Jun 4 Jun

10:30 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Tue, 04 Jun 2019 17:30:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6 Jun 6 Jun

7:18 a.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#7).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 1 insertion(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Marshall Dawson (Code Review)

1:09 p.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/33013/8/src/northbridge/amd/amdfam10/northbr... File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/33013/8/src/northbridge/amd/amdfam10/northbr... PS8, Line 1583: model model looks unassigned now. Am I missing it somewhere?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 06 Jun 2019 20:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:21 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 8:

thank you I've fixed it on patch set 6 ... I don't know what happen ....

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 06 Jun 2019 20:21:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:24 p.m.

Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33013

to look at the new patch set (#9).

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 2 insertions(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33013/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

15 Jun 15 Jun

1:08 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/33013/8/src/northbridge/amd/amdfam10/northbr... File src/northbridge/amd/amdfam10/northbridge.c:

https://review.coreboot.org/#/c/33013/8/src/northbridge/amd/amdfam10/northbr... PS8, Line 1583: model

...

model looks unassigned now. […]

Thx for the review

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Sat, 15 Jun 2019 08:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 Jun 21 Jun

2:06 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 21 Jun 2019 09:06:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:06 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33013 )

Change subject: nb/amd/amdfam10/northbridge.c: Remove variable set but not used ......................................................................

nb/amd/amdfam10/northbridge.c: Remove variable set but not used

Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33013 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/amd/amdfam10/northbridge.c 1 file changed, 2 insertions(+), 29 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index a681961..0c594b9 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -209,15 +209,6 @@ */ f3xe8 = pci_read_config32(get_node_pci(nodeid, 3), 0xe8); uint8_t internal_node_number = ((f3xe8 & 0xc0000000) >> 30); - uint8_t defective_link_number_1; - uint8_t defective_link_number_2; - if (is_fam15h()) { - defective_link_number_1 = 4; /* Link 0 Sublink 1 */ - defective_link_number_2 = 7; /* Link 3 Sublink 1 */ - } else { - defective_link_number_1 = 6; /* Link 2 Sublink 1 */ - defective_link_number_2 = 5; /* Link 1 Sublink 1 */ - } if (internal_node_number == 0) { /* Node 0 */ if (link->link_num == 6) /* Link 2 Sublink 1 */ @@ -745,7 +736,6 @@ uint8_t node; uint8_t interleaved; int8_t range; - int8_t max_range; uint8_t max_node; uint64_t max_range_limit; uint32_t dword; @@ -756,7 +746,6 @@ /* Find highest DRAM range (DramLimitAddr) */ num_nodes = 0; max_node = 0; - max_range = -1; interleaved = 0; max_range_limit = 0; struct device *node_dev; @@ -782,7 +771,6 @@ qword |= (((uint64_t)dword2) & 0xff) << 40;

if (qword > max_range_limit) { - max_range = range; max_range_limit = qword; max_node = dword & 0x7; } @@ -904,7 +892,6 @@ struct bus *link; #if CONFIG_HW_MEM_HOLE_SIZEK != 0 struct hw_mem_hole_info mem_hole; - u32 reset_memhole = 1; #endif

pci_tolm = 0xffffffffUL; @@ -935,7 +922,6 @@ // Use hole_basek as mmio_basek, and we don't need to reset hole anymore if ((mem_hole.node_id != -1) && (mmio_basek > mem_hole.hole_startk)) { mmio_basek = mem_hole.hole_startk; - reset_memhole = 0; }

#endif @@ -1542,7 +1528,6 @@ uint8_t rev_gte_d = 0; uint8_t dual_node = 0; uint32_t f3xe8; - uint32_t family; uint32_t model;

busn = CONFIG_CBB; @@ -1583,7 +1568,7 @@

f3xe8 = pci_read_config32(get_node_pci(0, 3), 0xe8);

- family = model = cpuid_eax(0x80000001); + model = cpuid_eax(0x80000001); model = ((model & 0xf0000) >> 12) | ((model & 0xf0) >> 4);

if (is_fam15h()) { @@ -1691,17 +1676,14 @@

uint8_t fam15h = 0; uint8_t rev_gte_d = 0; - unsigned nb_cfg_54; - uint32_t family; uint32_t model;

- family = model = cpuid_eax(0x80000001); + model = cpuid_eax(0x80000001); model = ((model & 0xf0000) >> 12) | ((model & 0xf0) >> 4);

if (is_fam15h()) { /* Family 15h or later */ fam15h = 1; - nb_cfg_54 = 1; }

if ((model >= 0x8) || fam15h) @@ -1862,20 +1844,11 @@ uint8_t cu_enabled; uint8_t compute_unit_count = 0;

- uint32_t f3xe8; - uint8_t dual_node = 0; - for (i = 0; i < sysconf.nodes; i++) { struct device *f3x_dev = pcidev_on_root(0x18 + i, 3); struct device *f4x_dev = pcidev_on_root(0x18 + i, 4); struct device *f5x_dev = pcidev_on_root(0x18 + i, 5);

- f3xe8 = pci_read_config32(f3x_dev, 0xe8); - - /* Check for dual node capability */ - if (f3xe8 & 0x20000000) - dual_node = 1; - /* Determine the number of active compute units on this node */ f5x80 = pci_read_config32(f5x_dev, 0x80); cu_enabled = f5x80 & 0xf;

-- To view, visit https://review.coreboot.org/c/coreboot/+/33013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62a51b794dedcf320b8054125e75aa041035ce33 Gerrit-Change-Number: 33013 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1976

days inactive

2003

days old

coreboot-gerrit@coreboot.org

15 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Marshall Dawson (Code Review)
Patrick Georgi (Code Review)