HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34261 )
Change subject: soc/amd/picasso: Add missing typedef gpio_t ......................................................................
soc/amd/picasso: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: Idfa1cfa1249e2cb7c5c5722d5140686d74c02c78 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/picasso/include/soc/gpio.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34261/1
diff --git a/src/soc/amd/picasso/include/soc/gpio.h b/src/soc/amd/picasso/include/soc/gpio.h index 411144b..772eeaa 100644 --- a/src/soc/amd/picasso/include/soc/gpio.h +++ b/src/soc/amd/picasso/include/soc/gpio.h @@ -23,6 +23,9 @@ #include <soc/iomap.h> #include <amdblocks/gpio_banks.h>
+/* <soc/gpio.h> must typedef a gpio_t that fits in 32 bits. */ +typedef uint32_t gpio_t; + /* The following sections describe only the GPIOs defined for this SOC */
#define SOC_GPIO_TOTAL_PINS 149
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34261 )
Change subject: soc/amd/picasso: Add missing typedef gpio_t ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34261/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/34261/1/src/soc/amd/picasso/include... PS1, Line 24: #include <amdblocks/gpio_banks.h> defined in here?
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34261 )
Change subject: soc/amd/picasso: Add missing typedef gpio_t ......................................................................
Abandoned
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/34261 )
Change subject: soc/amd/picasso: Add missing typedef gpio_t ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34261
to look at the new patch set (#2).
Change subject: soc/{amd,intel}: Add typedef gpio_t to <soc/gpio.h> ......................................................................
soc/{amd,intel}: Add typedef gpio_t to <soc/gpio.h>
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: Idfa1cfa1249e2cb7c5c5722d5140686d74c02c78 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/picasso/include/soc/gpio.h M src/soc/amd/stoneyridge/include/soc/gpio.h M src/soc/intel/apollolake/include/soc/gpio.h M src/soc/intel/baytrail/include/soc/gpio.h M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/cannonlake/include/soc/gpio.h M src/soc/intel/denverton_ns/include/soc/gpio.h M src/soc/intel/fsp_baytrail/include/soc/gpio.h M src/soc/intel/icelake/include/soc/gpio.h 9 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34261/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34261 )
Change subject: soc/{amd,intel}: Add typedef gpio_t to <soc/gpio.h> ......................................................................
Abandoned
see 34233
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)