Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
soc/intel/fsp-car: Use the coreboot defined stack
The stack needs to be in the coreboot defined region to not collide with other symbols.
Change-Id: I02a379d2ac73ae30239bd45859c3f09de1a9d0e0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/37278/1
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S index ec43311..d7ef834 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S @@ -87,7 +87,7 @@ jnz .halt_forever
/* Setup bootblock stack */ - mov %edx, %esp + movl _ecar_stack, %esp
/* coreboot assumes CAR region will be zero */ cld
Hello Patrick Rudolph, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37278
to look at the new patch set (#2).
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
soc/intel/fsp-car: Use the coreboot defined stack
The stack needs to be in the coreboot defined region to not collide with other symbols.
Change-Id: I02a379d2ac73ae30239bd45859c3f09de1a9d0e0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/37278/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
Patch Set 2: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
Removed Code-Review+2 by Kyösti Mälkki kyosti.malkki@gmail.com
Hello build bot (Jenkins), Frans Hendriks, Angel Pons, Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37278
to look at the new patch set (#3).
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
soc/intel/fsp-car: Use the coreboot defined stack
The stack needs to be in the coreboot defined region to not collide with other symbols.
Change-Id: I02a379d2ac73ae30239bd45859c3f09de1a9d0e0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/37278/3
Hello build bot (Jenkins), Frans Hendriks, Angel Pons, Subrata Banik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37278
to look at the new patch set (#4).
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
soc/intel/fsp-car: Use the coreboot defined stack
The stack needs to be in the coreboot defined region to not collide with other symbols.
Change-Id: I02a379d2ac73ae30239bd45859c3f09de1a9d0e0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/37278/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
Patch Set 4: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37278 )
Change subject: soc/intel/fsp-car: Use the coreboot defined stack ......................................................................
soc/intel/fsp-car: Use the coreboot defined stack
The stack needs to be in the coreboot defined region to not collide with other symbols.
Change-Id: I02a379d2ac73ae30239bd45859c3f09de1a9d0e0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37278 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S index e77b841..04dc533 100644 --- a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S +++ b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S @@ -71,7 +71,7 @@ jnz .halt_forever
/* Setup bootblock stack */ - mov %edx, %esp + movl $_ecar_stack, %esp /* * temp_memory_start/end reside in the .bss section, which gets cleared * below. Save the FSP return value to the stack before writing those
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Frans Hendriks (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)