Change in coreboot[master]: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Add code to check prerequisites before sending HMRFPO_GET_STATUS command.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38799/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 80f5a49..6035aaf 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -730,6 +730,11 @@
printk(BIOS_INFO, "HECI: Sending Get HMRFPO Status Command\n");
+ if (!cse_is_hfs1_cws_normal()) { + printk(BIOS_ERR, "HECI: CSE does not meet required prerequisites\n"); + return -1; + } + if (!heci_send_receive(&msg, sizeof(struct hmrfpo_get_status_msg), &resp, &resp_size)) { printk(BIOS_ERR, "HECI: HMRFPO send/receive fail\n");
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38799/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38799/1/src/soc/intel/common/block/... PS1, Line 734: CSE does not meet required prerequisites can we just say "current working state of CSE is not normal"
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG@9 PS1, Line 9: Add code to check prerequisites before sending HMRFPO_GET_STATUS comman nit: I know that the information will be part of CSE BIOS spec, would be helpful to mention the prerequisites here or in the comment for the function.
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38799
to look at the new patch set (#2).
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Send HMRFPO_GET_STATUS command when CSE's current working state is Normal.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38799/2
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38799/1//COMMIT_MSG@9 PS1, Line 9: Add code to check prerequisites before sending HMRFPO_GET_STATUS comman
nit: I know that the information will be part of CSE BIOS spec, would be helpful to mention the prer […]
Done
https://review.coreboot.org/c/coreboot/+/38799/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38799/1/src/soc/intel/common/block/... PS1, Line 734: CSE does not meet required prerequisites
can we just say "current working state of CSE is not normal"
Done
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38799
to look at the new patch set (#3).
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Send HMRFPO_GET_STATUS command when CSE's current working state is Normal.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38799/3
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
Patch Set 3: Code-Review+2
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38799
to look at the new patch set (#5).
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Send HMRFPO_GET_STATUS command when CSE's current working state is Normal.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38799/5
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38799
to look at the new patch set (#6).
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Send HMRFPO_GET_STATUS command when CSE's current working state is Normal.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38799/6
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38799 )
Change subject: soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command ......................................................................
soc/intel/common: Check prerequisites for HMRFPO_GET_STATUS command
Send HMRFPO_GET_STATUS command when CSE's current working state is Normal.
TEST=Verified on hatch.
Change-Id: I4380e5096c6346d88aae6826d19a2f4ed1e97036 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38799 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 39c30e9..afce985 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -713,6 +713,11 @@
printk(BIOS_INFO, "HECI: Sending Get HMRFPO Status Command\n");
+ if (!cse_is_hfs1_cws_normal()) { + printk(BIOS_ERR, "HECI: CSE's current working state is not Normal\n"); + return -1; + } + if (!heci_send_receive(&msg, sizeof(struct hmrfpo_get_status_msg), &resp, &resp_size)) { printk(BIOS_ERR, "HECI: HMRFPO send/receive fail\n");
-
Patrick Georgi (Code Review) -
Rizwan Qureshi (Code Review)
-
Sridhar Siricilla (Code Review)