Attention is currently required from: Jason Glenesk, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50463 )
Change subject: soc/amd: move southbridge_smi_handler to common code
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I've always been cautious about moving SMIxnn register handling to common. […]
i verified stoneyridge, picasso and cezanne and even the older non-soc chips looked to be the same, so i'm confident enough to put it into the common code directory. i kept the defines in the soc-specific code, although the relevant ones are the same and the code has assumptions about some of the registers
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I650498321736eee3d33af51216eda1b650f11744
Gerrit-Change-Number: 50463
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Wed, 10 Feb 2021 21:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment