Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48323 )
Change subject: soc/intel/skylake: Enable CHAP device depending on devicetree
......................................................................
Patch Set 4:
should probably be done in Kconfig.
I agree, or more configuration options are added to CMOS. But should we get this in first?
Do you actually need that device or do you add it because it's there?
Adding it because it's there, so that options in coreboot work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc51f7b9cda32d5058dce958e386921b6d3d8ffb
Gerrit-Change-Number: 48323
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Dec 2020 19:48:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment