Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45826 )
Change subject: soc/intel/icl: enable common CPU code ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45826/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45826/5//COMMIT_MSG@13 PS5, Line 13: like done for SKL,ICL,... already. This isn't quite clear, IMHO. "like done for [...]ICL"? but this is ICL. I see that the config value is already used in code. That could be clearer.
Also, there is another Kconfig prompt (locking) enabled by this which is not used, AFAICS. If that is the case, its prompt should be disabled. Either via another Kconfig (HAVE...LOCKING_OPTION?) or at least select it (prompt would show but can't be changed, which I assume is what the code does).