Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: src/arch/x86:Add support for low power idle table ......................................................................
Patch Set 4:
(10 comments)
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@7 PS4, Line 7: low power idle table Use LPIT here, and the full name in the commit message body.
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@7 PS4, Line 7: src/arch/x86:Add 1. `src/` not needed. 2. Please add a space after the colon
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@9 PS4, Line 9: residency.Residencies Space after .
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@13 PS4, Line 13: CPU PKG C10 (Read via FFH interface) : Platform Controller Hub (PCH) SLP_S0 (Read via memory mapped interface) Please add blank lines around, and format it as a list.
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@17 PS4, Line 17: /sys/devices/system/cpu/cpuidle/low_power_idle_cpu_residency_us : /sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us Please indent with four spaces, and add blank lines around the block.
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@21 PS4, Line 21: The “low_power_idle_system_residency_us” attribute shows SLP_S0 residency, or Please add a blank line above to separate paragraphs visually.
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@26 PS4, Line 26: Example: Please add a blank line above.
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@28 PS4, Line 28: thet that
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@31 PS4, Line 31: elected selected
https://review.coreboot.org/c/coreboot/+/32350/4//COMMIT_MSG@31 PS4, Line 31: thet that
-
Paul Menzel (Code Review)