Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `hostbridge.c` ......................................................................
soc/intel/broadwell/systemagent.c: Rename to `hostbridge.c`
Change-Id: Id1a0e02174456bb25df0721cfd3865645641a01a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Makefile.inc R src/soc/intel/broadwell/northbridge.c 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/46797/1
diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.inc index 7ee6990..7d21665 100644 --- a/src/soc/intel/broadwell/Makefile.inc +++ b/src/soc/intel/broadwell/Makefile.inc @@ -17,11 +17,11 @@ romstage-y += memmap.c postcar-y += memmap.c ramstage-y += minihd.c +ramstage-y += northbridge.c ramstage-y += pei_data.c romstage-y += pei_data.c ramstage-y += ramstage.c ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c -ramstage-y += systemagent.c
CPPFLAGS_common += -Isrc/soc/intel/broadwell/include
diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/northbridge.c similarity index 100% rename from src/soc/intel/broadwell/systemagent.c rename to src/soc/intel/broadwell/northbridge.c
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `hostbridge.c` ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG@7 PS6, Line 7: hostbridge.c northbridge.c?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `hostbridge.c` ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG@7 PS6, Line 7: hostbridge.c
northbridge. […]
Uh yes
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46797
to look at the new patch set (#8).
Change subject: soc/intel/broadwell/systemagent.c: Rename to `northbridge.c` ......................................................................
soc/intel/broadwell/systemagent.c: Rename to `northbridge.c`
Change-Id: Id1a0e02174456bb25df0721cfd3865645641a01a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/Makefile.inc R src/soc/intel/broadwell/northbridge.c 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/46797/8
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `northbridge.c` ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46797/6//COMMIT_MSG@7 PS6, Line 7: hostbridge.c
Uh yes
Done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `northbridge.c` ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46797 )
Change subject: soc/intel/broadwell/systemagent.c: Rename to `northbridge.c` ......................................................................
soc/intel/broadwell/systemagent.c: Rename to `northbridge.c`
Change-Id: Id1a0e02174456bb25df0721cfd3865645641a01a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46797 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/soc/intel/broadwell/Makefile.inc R src/soc/intel/broadwell/northbridge.c 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.inc index 7ee6990..7d21665 100644 --- a/src/soc/intel/broadwell/Makefile.inc +++ b/src/soc/intel/broadwell/Makefile.inc @@ -17,11 +17,11 @@ romstage-y += memmap.c postcar-y += memmap.c ramstage-y += minihd.c +ramstage-y += northbridge.c ramstage-y += pei_data.c romstage-y += pei_data.c ramstage-y += ramstage.c ramstage-$(CONFIG_HAVE_REFCODE_BLOB) += refcode.c -ramstage-y += systemagent.c
CPPFLAGS_common += -Isrc/soc/intel/broadwell/include
diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/northbridge.c similarity index 100% rename from src/soc/intel/broadwell/systemagent.c rename to src/soc/intel/broadwell/northbridge.c
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Patrick Georgi (Code Review)