Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define Devices by absolute path ......................................................................
*.asl: Don't define Devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general make the resulting code more readable as it avoid '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M util/autoport/main.go 7 files changed, 42 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/1
diff --git a/src/mainboard/asus/h61m-cs/dsdt.asl b/src/mainboard/asus/h61m-cs/dsdt.asl index 0e1cc3a..a1a70c0 100644 --- a/src/mainboard/asus/h61m-cs/dsdt.asl +++ b/src/mainboard/asus/h61m-cs/dsdt.asl @@ -32,9 +32,11 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl>
- Device (_SB.PCI0) { - #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> - #include <southbridge/intel/bd82x6x/acpi/pch.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl index 1c7a620..2c14e8f 100644 --- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -34,10 +34,11 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl>
- Device (_SB.PCI0) - { - #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> - #include <southbridge/intel/bd82x6x/acpi/pch.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl b/src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl index 7ee12a0..e54b01b 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl @@ -37,10 +37,11 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl>
- Device (_SB.PCI0) - { - #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> - #include <southbridge/intel/bd82x6x/acpi/pch.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/src/mainboard/lenovo/t440p/dsdt.asl b/src/mainboard/lenovo/t440p/dsdt.asl index 82358aa..fd37f9e 100644 --- a/src/mainboard/lenovo/t440p/dsdt.asl +++ b/src/mainboard/lenovo/t440p/dsdt.asl @@ -37,10 +37,11 @@ #include <southbridge/intel/lynxpoint/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl>
- Device (_SB.PCI0) - { - #include <northbridge/intel/haswell/acpi/haswell.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> - #include <southbridge/intel/lynxpoint/acpi/pch.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/src/mainboard/msi/ms7707/dsdt.asl b/src/mainboard/msi/ms7707/dsdt.asl index d3e3602..6df1394 100644 --- a/src/mainboard/msi/ms7707/dsdt.asl +++ b/src/mainboard/msi/ms7707/dsdt.asl @@ -32,10 +32,11 @@ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> #include <southbridge/intel/common/acpi/sleepstates.asl>
- Device (_SB.PCI0) - { - #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> - #include <southbridge/intel/bd82x6x/acpi/pch.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/src/mainboard/supermicro/x10slm-f/dsdt.asl b/src/mainboard/supermicro/x10slm-f/dsdt.asl index 6ed19ee..8649a95 100644 --- a/src/mainboard/supermicro/x10slm-f/dsdt.asl +++ b/src/mainboard/supermicro/x10slm-f/dsdt.asl @@ -24,10 +24,11 @@ #include <southbridge/intel/common/acpi/sleepstates.asl> #include <cpu/intel/common/acpi/cpu.asl>
- Device (_SB.PCI0) - { - #include <northbridge/intel/haswell/acpi/haswell.asl> - #include <southbridge/intel/lynxpoint/acpi/pch.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + Scope (_SB) { + Device (PCI0) { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } } } diff --git a/util/autoport/main.go b/util/autoport/main.go index 03523a2..51d10cf 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -876,17 +876,20 @@ }
dsdt.WriteString(` - Device (_SB.PCI0) + Scope (_SB) { + Device (PCI0) + { `) for _, x := range DSDTPCI0Includes { if x.Comment != "" { fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment) } - fmt.Fprintf(dsdt, "\t\t#include <%s>\n", x.File) + fmt.Fprintf(dsdt, "\t\t\t#include <%s>\n", x.File) } dsdt.WriteString( - ` } + ` } + } } `)
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36600
to look at the new patch set (#2).
Change subject: *.asl: Don't define Devices by absolute path ......................................................................
*.asl: Don't define Devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general make the resulting code more readable as it avoid '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M util/autoport/main.go 7 files changed, 44 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/2
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36600
to look at the new patch set (#3).
Change subject: *.asl: Don't define devices by absolute path ......................................................................
*.asl: Don't define devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general this makes the resulting code more readable as it avoids '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/gigabyte/ga-h61m-s2pv/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M util/autoport/main.go 7 files changed, 44 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... PS3, Line 40: Scope (_SB) : { : Device (PCI0) : { Scope (_SB) { Device (PCI0) {
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/supermicro/x1... PS3, Line 27: Scope (_SB) : { : Device (PCI0) : { Scope (_SB) { Device (PCI0) {
https://review.coreboot.org/c/coreboot/+/36600/3/util/autoport/main.go File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/36600/3/util/autoport/main.go@879 PS3, Line 879: Scope (_SB) : { : Device (PCI0) : { Scope (_SB) { Device (PCI0) {
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... PS3, Line 40: Scope (_SB) : { : Device (PCI0) : {
Scope (_SB) { Device (PCI0) {
The tree is quite inconsistent about this.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG@11 PS3, Line 11: avoids '^' symbols How so? I'm confused... It doesn't seem to change anything.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG@11 PS3, Line 11: avoids '^' symbols
How so? I'm confused... It doesn't seem to change anything.
Agreed. I prefer reeducing the number of indentations on dsdt.asl
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36600/3/src/mainboard/lenovo/t440p/... PS3, Line 40: Scope (_SB) : { : Device (PCI0) : {
Scope (_SB) { […]
I have been advocating for _SB.PCI0 for a long while.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36600/3//COMMIT_MSG@11 PS3, Line 11: avoids '^' symbols
Agreed. I prefer reeducing the number of indentations on dsdt. […]
Indentation? why? we are at 3 tabs, that's still reasonable. But you are right, it seems this is all just a question of cosmetics. I don't care much, as long as the commit message makes sense ;)
HAOUAS Elyes has uploaded a new patch set (#4) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
*.asl: Don't define devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general this makes the resulting code more readable as it avoids '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M util/autoport/main.go 6 files changed, 35 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/4
HAOUAS Elyes has uploaded a new patch set (#5) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
*.asl: Don't define devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general this makes the resulting code more readable as it avoids '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M util/autoport/main.go 15 files changed, 86 insertions(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/5
HAOUAS Elyes has uploaded a new patch set (#6) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
*.asl: Don't define devices by absolute path
Be consistent with the rest tree and set the scope first when defining devices. In general this makes the resulting code more readable as it avoids '^' symbols.
Change-Id: I0b8dd33fac7cb1524d920b77e95c08b839157e8f Signed-off-by: Arthur Heymans arthur@aheymans.xyz Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/supermicro/x10slm-f/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M util/autoport/main.go 15 files changed, 85 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/36600/6
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36600 )
Change subject: *.asl: Don't define devices by absolute path ......................................................................
Abandoned
lost interest.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)