Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: arch/x86: Helper functions to get deterministic cache parameters
......................................................................
Patch Set 2:
(2 comments)
File src/arch/x86/cpu_common.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123527):
https://review.coreboot.org/c/coreboot/+/55965/comment/314d8d03_3a1b3132
PS2, Line 127: break;
break is not useful after a goto or return
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123527):
https://review.coreboot.org/c/coreboot/+/55965/comment/62f551c1_728a76de
PS2, Line 130: break;
break is not useful after a goto or return
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095
Gerrit-Change-Number: 55965
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 06 Jul 2021 16:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment