[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add delay in pmif_spmi.c - coreboot-gerrit

30 Dec 2024


      Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85799?usp=email )
Change subject: soc/mediatek/mt8196: Add delay in pmif_spmi.c
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85799/comment/64531c1b_792ad86c?usp... :
PS1, Line 18: 
remove the blank line
https://review.coreboot.org/c/coreboot/+/85799/comment/69b8801a_b2947190?usp... :
PS1, Line 19: Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
...
`Duplicate signature`
Please fix.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85799?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Gerrit-Change-Number: 85799
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Mon, 30 Dec 2024 11:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No