Attention is currently required from: Paul Menzel, Rob Barnes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51775 )
Change subject: chromeec: Rewrite google_chromeec_status_check
......................................................................
Patch Set 4:
(3 comments)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/51775/comment/43cbeca7_db100a32
PS4, Line 100: 1
I'm playing with this value right now, but I think this is the source of our problems. […]
Issue has been fixed.
https://review.coreboot.org/c/coreboot/+/51775/comment/0bc9ce90_cc9ca961
PS4, Line 105: return 0;
Print the stopwatch value in a spew message?
This call happens pretty frequently. I'm not sure that's really useful.
https://review.coreboot.org/c/coreboot/+/51775/comment/ab16a2e0_0f01dcf4
PS4, Line 108:
Please print a warning/error with the timeout value.
As mentioned above, I don't think that it's particularly useful, except during board bringup.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363ff7453bcf81581884f92797629a6f96d42580
Gerrit-Change-Number: 51775
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment