Attention is currently required from: Jonathan Zhang, Simon Chou, Christian Walter, Arthur Heymans.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71965 )
Change subject: soc/intel/xeon_sp/chip_common.c: Update attach_iio_stacks()
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/71965/comment/2b418aa6_2882e9de
PS2, Line 495: attach_iio_stacks
Johnny, thanks for the validation. […]
I submitted patchset 10 for this. BTW the below lint errors need to be fixed in CB:72439.
I think SOC_INTEL_PCIE_64BIT_ALLOC and SOC_INTEL_HAS_BIOS_DONE_MSR should be moved from xeon_sp/spr/Kconfig to the common xeon_sp/Kconfig?
Check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: CONFIG() used on unknown value (SOC_INTEL_PCIE_64BIT_ALLOC) at src/soc/intel/xeon_sp/chip_common.c:410.
#!!!!! Error: CONFIG() used on unknown value (SOC_INTEL_HAS_BIOS_DONE_MSR) at src/soc/intel/xeon_sp/finalize.c:89.
# 2 errors
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250
Gerrit-Change-Number: 71965
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 01 Feb 2023 03:44:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment