Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 )
Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/19503/10/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
PS10, Line 583: 128
Maybe define that in src/include/edid.h ?
can also be 256 for 2.0 edid although I have yet to come across those.
Line 716: /* Init graphics power management */
I wonder how far you have to go back so this comment makes sense again ;)
gma.c was introduced in 6481e1052fa88a4dcfb7220775ff67ecd3c70384 and even there it does not make sense.