Change in coreboot[master]: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

V Sowmya (Code Review)

11 Nov 2020 11 Nov '20

6:42 a.m.

V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions ......................................................................

mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions

Existing implemenation adds the CSE RW update binary to FW_MAIN_A/B regions and this has significant impact on boot time due to the increase in the size of these regions leading to higher loading and hashing time.

This patch modifies flash layout to add new CSE_RW_A/B fmap regions in the RW_SECTION_A/B.

BUG=b:169077783 TEST= Built for dedede. Verified that CSE RW binary is added to the CSE_RW_A/B fmap region.

Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd M src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd 2 files changed, 12 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47439/1

diff --git a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd index 0e21c4c..ec458d0 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd @@ -7,13 +7,15 @@ RW_LEGACY(CBFS)@0x0 0x100000 RW_SECTION_A@0x100000 0x3a4800 { VBLOCK_A@0x0 0x2000 - FW_MAIN_A(CBFS)@0x2000 0x3a27c0 - RW_FWID_A@0x3a47c0 0x40 + FW_MAIN_A(CBFS)@0x2000 0x2127c0 + RW_FWID_A@0x2147c0 0x40 + CSE_RW_A(CBFS)@0x214800 0x190000 } RW_SECTION_B@0x4a4800 0x3a4800 { VBLOCK_B@0x0 0x2000 - FW_MAIN_B(CBFS)@0x2000 0x3a27c0 - RW_FWID_B@0x3a47c0 0x40 + FW_MAIN_B(CBFS)@0x2000 0x2127c0 + RW_FWID_B@0x2147c0 0x40 + CSE_RW_B(CBFS)@0x214800 0x190000 } RW_MISC@0x849000 0x36000 { UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { diff --git a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd index 60ea3de..47eb446 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd @@ -10,13 +10,15 @@ RW_LEGACY(CBFS)@0x0 0xf00000 RW_SECTION_A@0xf00000 0x3e0000 { VBLOCK_A@0x0 0x10000 - FW_MAIN_A(CBFS)@0x10000 0x3cffc0 - RW_FWID_A@0x3dffc0 0x40 + FW_MAIN_A(CBFS)@0x10000 0x23ffc0 + RW_FWID_A@0x24ffc0 0x40 + CSE_RW_A(CBFS)@0x250000 0x190000 } RW_SECTION_B@0x12e0000 0x3e0000 { VBLOCK_B@0x0 0x10000 - FW_MAIN_B(CBFS)@0x10000 0x3cffc0 - RW_FWID_B@0x3dffc0 0x40 + FW_MAIN_B(CBFS)@0x10000 0x23ffc0 + RW_FWID_B@0x24ffc0 0x40 + CSE_RW_B(CBFS)@0x250000 0x190000 } RW_MISC@0x16c0000 0x40000 { UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 {

Attachments:

attachment.htm (text/html — 5.3 KB)

Show replies by date

Sridhar Siricilla (Code Review)

11 Nov 11 Nov

9:21 a.m.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions ......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd:

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 12: CSE_RW_A Use ME_RW_A inline with SI_ME.

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 18: ( Use ME_RW_B inline with SI_ME.

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd:

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 15: CSE_RW_A Use ME_RW_A inline with SI_ME.

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 21: CSE_RW_B Use ME_RW_B inline with SI_ME.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 11 Nov 2020 09:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

V Sowmya (Code Review)

1:12 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47439

to look at the new patch set (#2).

Change subject: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions ......................................................................

mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions

This patch modifies flash layout to add new CSE_RW_A/B fmap regions in the RW_SECTION_A/B.

BUG=b:169077783 TEST= Built for dedede. Verified that CSE RW binary is added to the CSE_RW_A/B fmap region.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47439/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

V Sowmya (Code Review)

2:10 p.m.

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions ......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd:

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 12: CSE_RW_A

...

Use ME_RW_A inline with SI_ME.

Done

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 18: (

...

Use ME_RW_B inline with SI_ME.

Done

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd:

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 15: CSE_RW_A

...

Use ME_RW_A inline with SI_ME.

Done

https://review.coreboot.org/c/coreboot/+/47439/1/src/mainboard/google/dedede... PS1, Line 21: CSE_RW_B

...

Use ME_RW_B inline with SI_ME.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Nov 2020 14:10:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-MessageType: comment

Sridhar Siricilla (Code Review)

12 Nov 12 Nov

4:50 p.m.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add CSE_RW_A/B regions ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47439/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47439/3//COMMIT_MSG@9 PS3, Line 9: implemenation implementation

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Nov 2020 16:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

V Sowmya (Code Review)

5:40 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Hello build bot (Jenkins), Furquan Shaikh, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47439

to look at the new patch set (#4).

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

This patch modifies flash layout to add new ME_RW_A/B fmap regions in the RW_SECTION_A/B.

BUG=b:169077783 TEST= Built for dedede. Verified that CSE RW binary is added to the CSE_RW_A/B fmap region.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47439/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 4 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

V Sowmya (Code Review)

5:43 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Hello build bot (Jenkins), Furquan Shaikh, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47439

to look at the new patch set (#5).

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Existing implementation adds the CSE RW update binary to FW_MAIN_A/B regions and this has significant impact on boot time due to the increase in the size of these regions leading to higher loading and hashing time.

This patch modifies flash layout to add new ME_RW_A/B fmap regions in the RW_SECTION_A/B.

BUG=b:169077783 TEST= Built for dedede. Verified that CSE RW binary is added to the CSE_RW_A/B fmap region.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/47439/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 5 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

V Sowmya (Code Review)

5:43 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47439/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47439/3//COMMIT_MSG@9 PS3, Line 9: implemenation

...

implementation

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 5 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Nov 2020 17:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

14 Nov 14 Nov

12:14 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

Patch Set 7: Code-Review+1

I haven't looked at the latest sizes for CSE RW binary on JSL. I will let Karthik +2 this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 7 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 14 Nov 2020 00:14:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

16 Nov 16 Nov

5:32 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

Patch Set 9: Code-Review+2

...

Patch Set 7: Code-Review+1

I haven't looked at the latest sizes for CSE RW binary on JSL. I will let Karthik +2 this.

CSE RW binary size is currently at 1576976 bytes (0x181010). Hence the ME_RW_A/B size of 0x190000 sounds good to me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 9 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Nov 2020 17:32:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

18 Nov 18 Nov

1:26 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47439 )

Change subject: mb/google/dedede: Modify flash layout to add ME_RW_A/B regions ......................................................................

mb/google/dedede: Modify flash layout to add ME_RW_A/B regions

This patch modifies flash layout to add new ME_RW_A/B fmap regions in the RW_SECTION_A/B.

BUG=b:169077783 TEST= Built for dedede. Verified that CSE RW binary is added to the CSE_RW_A/B fmap region.

Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Signed-off-by: V Sowmya v.sowmya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47439 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd M src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd 2 files changed, 12 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd index 0e21c4c..ade4866 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd @@ -7,13 +7,15 @@ RW_LEGACY(CBFS)@0x0 0x100000 RW_SECTION_A@0x100000 0x3a4800 { VBLOCK_A@0x0 0x2000 - FW_MAIN_A(CBFS)@0x2000 0x3a27c0 - RW_FWID_A@0x3a47c0 0x40 + FW_MAIN_A(CBFS)@0x2000 0x2127c0 + RW_FWID_A@0x2147c0 0x40 + ME_RW_A(CBFS)@0x214800 0x190000 } RW_SECTION_B@0x4a4800 0x3a4800 { VBLOCK_B@0x0 0x2000 - FW_MAIN_B(CBFS)@0x2000 0x3a27c0 - RW_FWID_B@0x3a47c0 0x40 + FW_MAIN_B(CBFS)@0x2000 0x2127c0 + RW_FWID_B@0x2147c0 0x40 + ME_RW_B(CBFS)@0x214800 0x190000 } RW_MISC@0x849000 0x36000 { UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 { diff --git a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd index 60ea3de..4b31861 100644 --- a/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd +++ b/src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd @@ -10,13 +10,15 @@ RW_LEGACY(CBFS)@0x0 0xf00000 RW_SECTION_A@0xf00000 0x3e0000 { VBLOCK_A@0x0 0x10000 - FW_MAIN_A(CBFS)@0x10000 0x3cffc0 - RW_FWID_A@0x3dffc0 0x40 + FW_MAIN_A(CBFS)@0x10000 0x23ffc0 + RW_FWID_A@0x24ffc0 0x40 + ME_RW_A(CBFS)@0x250000 0x190000 } RW_SECTION_B@0x12e0000 0x3e0000 { VBLOCK_B@0x0 0x10000 - FW_MAIN_B(CBFS)@0x10000 0x3cffc0 - RW_FWID_B@0x3dffc0 0x40 + FW_MAIN_B(CBFS)@0x10000 0x23ffc0 + RW_FWID_B@0x24ffc0 0x40 + ME_RW_B(CBFS)@0x250000 0x190000 } RW_MISC@0x16c0000 0x40000 { UNIFIED_MRC_CACHE(PRESERVE)@0x0 0x30000 {

-- To view, visit https://review.coreboot.org/c/coreboot/+/47439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a3e22a569488b39beb4d12f5b6309c7c742992 Gerrit-Change-Number: 47439 Gerrit-PatchSet: 11 Gerrit-Owner: V Sowmya v.sowmya@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1514

days inactive

1521

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Sridhar Siricilla (Code Review)
V Sowmya (Code Review)