[M] Change in coreboot[master]: drivers/i2c/sx9324: Add support for Linux's SX9324 driver
Attention is currently required from: Tarun Tuli, Jason Nien, Reka Norman, Martin Roth.
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69192 )
Change subject: drivers/i2c/sx9324: Add support for Linux's SX9324 driver ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69192/comment/20f3c18c_80033cfe PS3, Line 16:
I think this could do with slightly more explanation. I.e. […]
Done
https://review.coreboot.org/c/coreboot/+/69192/comment/faf8125a_27e6ce00 PS3, Line 18: TEST=Dump ACPI SSDT then verify they are identical w/ and w/o this patch
This is not true, since the new properties will be added to the ACPI tables with zero values.
Done
File src/drivers/i2c/sx9324/Kconfig:
https://review.coreboot.org/c/coreboot/+/69192/comment/be177cb1_282b6b47 PS3, Line 13: Board may use the legacy sx932x linux driver.
Could you add a few more details, similar to what I suggested for the commit message?
Done
File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/69192/comment/f7f4d9f2_ebc52903 PS3, Line 72: cs_idle_sleep
int_comp_resistor
Done
-
Victor Ding (Code Review)