Attention is currently required from: Francois Toguo Fotso, Martin Roth, Nikunj Dadhania, Patrick Rudolph. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49258 )
Change subject: This change implements CrashLog for intel TGL. ......................................................................
Patch Set 5:
(4 comments)
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/49258/comment/4d0445b6_0a0edcbb PS5, Line 63: BERT_REGION_MAX_SIZE Save as above
File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/49258/comment/4cd3ca43_ac5a9bf6 PS5, Line 402: "Error: Crashlog CPU entry(size %lu) would exceed available region\n", why not also print as previous line? printk(BIOS_ERR, "Error: Crashlog CPU entry(size %lu) " "would exceed available region\n",
https://review.coreboot.org/c/coreboot/+/49258/comment/b2a513e3_c2e31610 PS5, Line 422: Error: Crashlog PMC entry(size %lu) would exceed available region\n", Same as above
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49258/comment/eadf53a6_7324d1c0 PS5, Line 219: m_cfg->CpuCrashLogDevice = 1; : m_cfg->CpuCrashLogEnable = 1; Always enable or need to base on SOC_INTEL_CRASHLOG?