Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74805 )
Change subject: soc/intel: Make CSE sync in romstage default disable
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/74805/comment/f87857ed_94cabcb3
PS2, Line 115: if SOC_INTEL_CSE_LITE_SKU
Hmm why this flag is required when SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE itself indicate that deals with CSE Lite? May be it(SOC_INTEL_CSE_LITE_SKU) can be added as dependent to KConfig SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE. I don't see need for this condition here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5017fbcf917201eaf8233089050bd31c3d1917
Gerrit-Change-Number: 74805
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment