Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
mb/**/hda_verb.c: use denary numerals for lengths
Change-Id: Ia22705d7629a322292cfd557add9cfadc649c16c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/apple/macbookair4_2/hda_verb.c M src/mainboard/asrock/b75pro3-m/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/asus/p8z77-m_pro/hda_verb.c M src/mainboard/compulab/intense_pc/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/hp/2570p/hda_verb.c M src/mainboard/hp/2760p/hda_verb.c M src/mainboard/hp/8460p/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/hp/8770w/hda_verb.c M src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c M src/mainboard/hp/folio_9470m/hda_verb.c M src/mainboard/hp/revolve_810_g1/hda_verb.c M src/mainboard/hp/z220_sff_workstation/hda_verb.c M src/mainboard/intel/dcp847ske/hda_verb.c M src/mainboard/lenovo/l520/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t410/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c M src/mainboard/lenovo/x201/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/msi/ms7707/hda_verb.c M src/mainboard/packardbell/ms2290/hda_verb.c M src/mainboard/sapphire/pureplatinumh61/hda_verb.c 39 files changed, 69 insertions(+), 69 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37537/1
diff --git a/src/mainboard/apple/macbook21/hda_verb.c b/src/mainboard/apple/macbook21/hda_verb.c index 09d5f1a..b19cf9c 100644 --- a/src/mainboard/apple/macbook21/hda_verb.c +++ b/src/mainboard/apple/macbook21/hda_verb.c @@ -22,7 +22,7 @@ #if CONFIG(BOARD_APPLE_MACBOOK11) || \ CONFIG(BOARD_APPLE_MACBOOK21) 0x106b2200, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106B2200), @@ -58,7 +58,7 @@ AZALIA_PIN_CFG(0x0, 0x1B, 0x400000FB), #else /* CONFIG_BOARD_APPLE_IMAC52 */ 0x106b0f00, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106b0f00), diff --git a/src/mainboard/apple/macbookair4_2/hda_verb.c b/src/mainboard/apple/macbookair4_2/hda_verb.c index 6ca5f51..69a165c 100644 --- a/src/mainboard/apple/macbookair4_2/hda_verb.c +++ b/src/mainboard/apple/macbookair4_2/hda_verb.c @@ -17,7 +17,7 @@ 0x10134206, /* Codec Vendor / Device ID: Cirrus */ 0x106b5b00, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106b5b00),
@@ -53,7 +53,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asrock/b75pro3-m/hda_verb.c b/src/mainboard/asrock/b75pro3-m/hda_verb.c index cae9137..d7e41b7 100644 --- a/src/mainboard/asrock/b75pro3-m/hda_verb.c +++ b/src/mainboard/asrock/b75pro3-m/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x18498892, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x18498892),
@@ -69,7 +69,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asrock/h110m/hda_verb.c b/src/mainboard/asrock/h110m/hda_verb.c index 2fb0fe7..6e13784 100644 --- a/src/mainboard/asrock/h110m/hda_verb.c +++ b/src/mainboard/asrock/h110m/hda_verb.c @@ -41,7 +41,7 @@ /* coreboot specific header */ 0x80862809, /* Codec Vendor / Device ID: Intel Skylake HDMI */ 0x80860101, - 0x00000004, + 4, /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x2, 0x80860101),
diff --git a/src/mainboard/asus/p8h61-m_pro/hda_verb.c b/src/mainboard/asus/p8h61-m_pro/hda_verb.c index 13b25ed..05a2b39 100644 --- a/src/mainboard/asus/p8h61-m_pro/hda_verb.c +++ b/src/mainboard/asus/p8h61-m_pro/hda_verb.c @@ -19,7 +19,7 @@ 0x10ec0887, /* Codec Vendor / Device ID: Realtek */ 0x10438444, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10438444),
@@ -67,7 +67,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asus/p8z77-m_pro/hda_verb.c b/src/mainboard/asus/p8z77-m_pro/hda_verb.c index 4fd3fcc..1f22a7c 100644 --- a/src/mainboard/asus/p8z77-m_pro/hda_verb.c +++ b/src/mainboard/asus/p8z77-m_pro/hda_verb.c @@ -22,7 +22,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x10438436, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* Subsystem ID */ AZALIA_SUBVENDOR(0x0, 0x10438436),
@@ -43,7 +43,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* Subsystem ID */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/compulab/intense_pc/hda_verb.c b/src/mainboard/compulab/intense_pc/hda_verb.c index 5cade62..c71d83b 100644 --- a/src/mainboard/compulab/intense_pc/hda_verb.c +++ b/src/mainboard/compulab/intense_pc/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0888, /* Codec Vendor / Device ID: Realtek */ 0x10ec0888, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10ec0888),
@@ -69,7 +69,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c index 93c7e11..a0e0614 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c @@ -19,7 +19,7 @@ const u32 cim_verb_data[] = { 0x10ec0887, /* Realtek ALC887 */ 0x1458a002, /* Subsystem ID */ - 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x2, 0x1458a002), AZALIA_PIN_CFG(0x2, 0x11, 0x411111f0), AZALIA_PIN_CFG(0x2, 0x12, 0x411111f0), diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c index e160538..8860993 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c @@ -19,7 +19,7 @@ const u32 cim_verb_data[] = { 0x10ec0887, /* Realtek ALC887 */ 0x1458a002, /* Subsystem ID */ - 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x2, 0x1458a002), AZALIA_PIN_CFG(0x2, 0x11, 0x411110f0), AZALIA_PIN_CFG(0x2, 0x12, 0x411111f0), diff --git a/src/mainboard/google/butterfly/hda_verb.c b/src/mainboard/google/butterfly/hda_verb.c index caf8b4a..fc34e56 100644 --- a/src/mainboard/google/butterfly/hda_verb.c +++ b/src/mainboard/google/butterfly/hda_verb.c @@ -26,7 +26,7 @@ /* coreboot specific header */ 0x111D76E5, // Codec Vendor / Device ID: IDT 92HD99 0x103C18F9, // Subsystem ID - 0x00000073, // Number of 4 dword sets + 115, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -206,7 +206,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/hp/2570p/hda_verb.c b/src/mainboard/hp/2570p/hda_verb.c index 3c4c734..a8e0729 100644 --- a/src/mainboard/hp/2570p/hda_verb.c +++ b/src/mainboard/hp/2570p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c17df, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c17df),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/2760p/hda_verb.c b/src/mainboard/hp/2760p/hda_verb.c index 6a62cf1..48b730a 100644 --- a/src/mainboard/hp/2760p/hda_verb.c +++ b/src/mainboard/hp/2760p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c162a, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c162a),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/8460p/hda_verb.c b/src/mainboard/hp/8460p/hda_verb.c index 8436707..96430133 100644 --- a/src/mainboard/hp/8460p/hda_verb.c +++ b/src/mainboard/hp/8460p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c3588, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c3588),
@@ -57,7 +57,7 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), }; diff --git a/src/mainboard/hp/8470p/hda_verb.c b/src/mainboard/hp/8470p/hda_verb.c index 0d7389a..a24aeb2 100644 --- a/src/mainboard/hp/8470p/hda_verb.c +++ b/src/mainboard/hp/8470p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c17c2, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c17c2),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/8770w/hda_verb.c b/src/mainboard/hp/8770w/hda_verb.c index 51869cb..cc66a31 100644 --- a/src/mainboard/hp/8770w/hda_verb.c +++ b/src/mainboard/hp/8770w/hda_verb.c @@ -22,7 +22,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c176c, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c176c),
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c b/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c index 4b90aab..907ad2f 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c +++ b/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0662, /* Codec Vendor / Device ID: Realtek */ 0x103c1495, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c1495),
@@ -57,7 +57,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80861495, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80861495),
diff --git a/src/mainboard/hp/folio_9470m/hda_verb.c b/src/mainboard/hp/folio_9470m/hda_verb.c index 3abd5be..14d181f 100644 --- a/src/mainboard/hp/folio_9470m/hda_verb.c +++ b/src/mainboard/hp/folio_9470m/hda_verb.c @@ -21,7 +21,7 @@ 0x111d76e0, /* Codec Vendor / Device ID: IDT */ 0x103c18df, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c18df),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/revolve_810_g1/hda_verb.c b/src/mainboard/hp/revolve_810_g1/hda_verb.c index c7d5662..693ee40 100644 --- a/src/mainboard/hp/revolve_810_g1/hda_verb.c +++ b/src/mainboard/hp/revolve_810_g1/hda_verb.c @@ -21,7 +21,7 @@ 0x111d76e0, /* Codec Vendor / Device ID: IDT */ 0x103c18f8, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c18f8),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/z220_sff_workstation/hda_verb.c b/src/mainboard/hp/z220_sff_workstation/hda_verb.c index 91804c1..9ded3ec 100644 --- a/src/mainboard/hp/z220_sff_workstation/hda_verb.c +++ b/src/mainboard/hp/z220_sff_workstation/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0221, /* Codec Vendor / Device ID: Realtek */ 0x103c1791, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c1791),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x103c1791, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x103c1791),
diff --git a/src/mainboard/intel/dcp847ske/hda_verb.c b/src/mainboard/intel/dcp847ske/hda_verb.c index b000347..3b7190d 100644 --- a/src/mainboard/intel/dcp847ske/hda_verb.c +++ b/src/mainboard/intel/dcp847ske/hda_verb.c @@ -21,7 +21,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/l520/hda_verb.c b/src/mainboard/lenovo/l520/hda_verb.c index 30a4a61..bca06f5 100644 --- a/src/mainboard/lenovo/l520/hda_verb.c +++ b/src/mainboard/lenovo/l520/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa21de, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa21de),
@@ -57,7 +57,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/s230u/hda_verb.c b/src/mainboard/lenovo/s230u/hda_verb.c index f2da2c4..2433e99 100644 --- a/src/mainboard/lenovo/s230u/hda_verb.c +++ b/src/mainboard/lenovo/s230u/hda_verb.c @@ -22,7 +22,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x0000000c, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -106,7 +106,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t410/hda_verb.c b/src/mainboard/lenovo/t410/hda_verb.c index 752e5da..2b871f6 100644 --- a/src/mainboard/lenovo/t410/hda_verb.c +++ b/src/mainboard/lenovo/t410/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x14F15069, /* Codec Vendor / Device ID: Conexant CX20585 */ 0x17AA214C, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17AA214C), AZALIA_PIN_CFG(0x0, 0x19, 0x042110F0), @@ -36,7 +36,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x17AA21B5, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x3, 0x17AA21B5), AZALIA_PIN_CFG(0x3, 0x04, 0x18560010), diff --git a/src/mainboard/lenovo/t420/hda_verb.c b/src/mainboard/lenovo/t420/hda_verb.c index 18a61a2..9287d4a 100644 --- a/src/mainboard/lenovo/t420/hda_verb.c +++ b/src/mainboard/lenovo/t420/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic show CX20672 0x17aa21ce, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t420s/hda_verb.c b/src/mainboard/lenovo/t420s/hda_verb.c index cad2050..8a9c3e5 100644 --- a/src/mainboard/lenovo/t420s/hda_verb.c +++ b/src/mainboard/lenovo/t420s/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic show CX20672 0x17aa21d2, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t430/hda_verb.c b/src/mainboard/lenovo/t430/hda_verb.c index 02f433f..255198f 100644 --- a/src/mainboard/lenovo/t430/hda_verb.c +++ b/src/mainboard/lenovo/t430/hda_verb.c @@ -55,7 +55,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c b/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c index f73434d..c5c17b8 100644 --- a/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c +++ b/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fb, // Subsystem ID - 0x00000013, // Number of 4 dword sets + 19, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -105,7 +105,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c b/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c index 179fba0..1c5d376 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa2208, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa2208),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/t520/hda_verb.c b/src/mainboard/lenovo/t520/hda_verb.c index dae692d..2d10e35 100644 --- a/src/mainboard/lenovo/t520/hda_verb.c +++ b/src/mainboard/lenovo/t520/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic shows CX20672 0x17aa21cf, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t530/hda_verb.c b/src/mainboard/lenovo/t530/hda_verb.c index 154b314..f8876aa 100644 --- a/src/mainboard/lenovo/t530/hda_verb.c +++ b/src/mainboard/lenovo/t530/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x00000012, // Number of 4 dword sets + 18, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -104,7 +104,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t60/hda_verb.c b/src/mainboard/lenovo/t60/hda_verb.c index 3507776..216696b 100644 --- a/src/mainboard/lenovo/t60/hda_verb.c +++ b/src/mainboard/lenovo/t60/hda_verb.c @@ -16,7 +16,7 @@ const u32 cim_verb_data[] = { 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */ 0x17aa2025, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17aa2025),
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c b/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c index 2a216d3..1946286 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c @@ -20,7 +20,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa21f9, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa21f9),
@@ -56,7 +56,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/x201/hda_verb.c b/src/mainboard/lenovo/x201/hda_verb.c index 820e2c5..25a87f5 100644 --- a/src/mainboard/lenovo/x201/hda_verb.c +++ b/src/mainboard/lenovo/x201/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x14F15069, /* Codec Vendor / Device ID: Conexant CX20585 */ 0x17AA2155, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17AA2155), @@ -57,7 +57,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x17aa21b5, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21b5 */ AZALIA_SUBVENDOR(0x3, 0x17AA21B5), diff --git a/src/mainboard/lenovo/x220/hda_verb.c b/src/mainboard/lenovo/x220/hda_verb.c index d94c320..b7b670d 100644 --- a/src/mainboard/lenovo/x220/hda_verb.c +++ b/src/mainboard/lenovo/x220/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 0x17aa21db, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -71,7 +71,7 @@ /* coreboot specific header */ 0x80862805, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/x230/hda_verb.c b/src/mainboard/lenovo/x230/hda_verb.c index 792579a..0393ff5 100644 --- a/src/mainboard/lenovo/x230/hda_verb.c +++ b/src/mainboard/lenovo/x230/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x00000013, // Number of 4 dword sets + 19, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -112,7 +112,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/x60/hda_verb.c b/src/mainboard/lenovo/x60/hda_verb.c index 3507776..216696b 100644 --- a/src/mainboard/lenovo/x60/hda_verb.c +++ b/src/mainboard/lenovo/x60/hda_verb.c @@ -16,7 +16,7 @@ const u32 cim_verb_data[] = { 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */ 0x17aa2025, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17aa2025),
diff --git a/src/mainboard/msi/ms7707/hda_verb.c b/src/mainboard/msi/ms7707/hda_verb.c index 6a6cf41..7ff2bee 100644 --- a/src/mainboard/msi/ms7707/hda_verb.c +++ b/src/mainboard/msi/ms7707/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0887, /* Codec Vendor / Device ID: Realtek */ 0x14627707, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x14627707),
diff --git a/src/mainboard/packardbell/ms2290/hda_verb.c b/src/mainboard/packardbell/ms2290/hda_verb.c index 1932ff9..d458cd6 100644 --- a/src/mainboard/packardbell/ms2290/hda_verb.c +++ b/src/mainboard/packardbell/ms2290/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x10ec0272, /* Codec Vendor / Device ID: Realtek ALC272X */ 0x10250379, /* Subsystem ID */ - 0x00000006, /* Number of 4 dword sets */ + 6, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10250379), @@ -42,7 +42,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x80860101, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21b5 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/sapphire/pureplatinumh61/hda_verb.c b/src/mainboard/sapphire/pureplatinumh61/hda_verb.c index cf723d0..9be242e 100644 --- a/src/mainboard/sapphire/pureplatinumh61/hda_verb.c +++ b/src/mainboard/sapphire/pureplatinumh61/hda_verb.c @@ -20,7 +20,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x10ec0000, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x2, 0x10ec0000),
@@ -68,7 +68,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37537
to look at the new patch set (#2).
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
mb/**/hda_verb.c: use denary numerals for lengths
Change-Id: Ia22705d7629a322292cfd557add9cfadc649c16c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/apple/macbookair4_2/hda_verb.c M src/mainboard/asrock/b75pro3-m/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/asus/p8z77-m_pro/hda_verb.c M src/mainboard/compulab/intense_pc/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/hp/2570p/hda_verb.c M src/mainboard/hp/2760p/hda_verb.c M src/mainboard/hp/8460p/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/hp/8770w/hda_verb.c M src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c M src/mainboard/hp/folio_9470m/hda_verb.c M src/mainboard/hp/revolve_810_g1/hda_verb.c M src/mainboard/hp/z220_sff_workstation/hda_verb.c M src/mainboard/intel/dcp847ske/hda_verb.c M src/mainboard/lenovo/l520/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t410/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c M src/mainboard/lenovo/x201/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/msi/ms7707/hda_verb.c M src/mainboard/packardbell/ms2290/hda_verb.c M src/mainboard/sapphire/pureplatinumh61/hda_verb.c 39 files changed, 69 insertions(+), 69 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37537/2
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... PS2, Line 25: 13 0c is 12
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... PS2, Line 25: 13
0c is 12
Oops
Hello Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37537
to look at the new patch set (#3).
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
mb/**/hda_verb.c: use denary numerals for lengths
Change-Id: Ia22705d7629a322292cfd557add9cfadc649c16c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/apple/macbookair4_2/hda_verb.c M src/mainboard/asrock/b75pro3-m/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/asus/p8z77-m_pro/hda_verb.c M src/mainboard/compulab/intense_pc/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/hp/2570p/hda_verb.c M src/mainboard/hp/2760p/hda_verb.c M src/mainboard/hp/8460p/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/hp/8770w/hda_verb.c M src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c M src/mainboard/hp/folio_9470m/hda_verb.c M src/mainboard/hp/revolve_810_g1/hda_verb.c M src/mainboard/hp/z220_sff_workstation/hda_verb.c M src/mainboard/intel/dcp847ske/hda_verb.c M src/mainboard/lenovo/l520/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t410/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c M src/mainboard/lenovo/x201/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/msi/ms7707/hda_verb.c M src/mainboard/packardbell/ms2290/hda_verb.c M src/mainboard/sapphire/pureplatinumh61/hda_verb.c 39 files changed, 69 insertions(+), 69 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37537/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... File src/mainboard/lenovo/s230u/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37537/2/src/mainboard/lenovo/s230u/... PS2, Line 25: 13
Oops
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37537/3//COMMIT_MSG@7 PS3, Line 7: denary decimal is probably more known? Add it to the description, so ignorant English speakers like myself do not have to look it up?
Hello Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37537
to look at the new patch set (#4).
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
mb/**/hda_verb.c: use denary numerals for lengths
Denary, also known as "decimal" or "base 10," is the standard number system used around the world. Therefore, make use of it.
Change-Id: Ia22705d7629a322292cfd557add9cfadc649c16c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/apple/macbookair4_2/hda_verb.c M src/mainboard/asrock/b75pro3-m/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/asus/p8z77-m_pro/hda_verb.c M src/mainboard/compulab/intense_pc/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/hp/2570p/hda_verb.c M src/mainboard/hp/2760p/hda_verb.c M src/mainboard/hp/8460p/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/hp/8770w/hda_verb.c M src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c M src/mainboard/hp/folio_9470m/hda_verb.c M src/mainboard/hp/revolve_810_g1/hda_verb.c M src/mainboard/hp/z220_sff_workstation/hda_verb.c M src/mainboard/intel/dcp847ske/hda_verb.c M src/mainboard/lenovo/l520/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t410/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c M src/mainboard/lenovo/x201/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/msi/ms7707/hda_verb.c M src/mainboard/packardbell/ms2290/hda_verb.c M src/mainboard/sapphire/pureplatinumh61/hda_verb.c 39 files changed, 69 insertions(+), 69 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37537/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37537/3//COMMIT_MSG@7 PS3, Line 7: denary
decimal is probably more known? Add it to the description, so ignorant English speakers like myself […]
*sigh* Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG@7 PS4, Line 7: use Use
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG@7 PS4, Line 7: use
Use
Why? I can't see anything in https://www.coreboot.org/Git#Commit_messages
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37537/4//COMMIT_MSG@7 PS4, Line 7: use
Why? I can't see anything in https://www.coreboot. […]
we start with a capital letter see here: https://www.coreboot.org/Git#Commit_messages : "examplecomponent: Refactor duplicated setup into a function"
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37537 )
Change subject: mb/**/hda_verb.c: use denary numerals for lengths ......................................................................
mb/**/hda_verb.c: use denary numerals for lengths
Denary, also known as "decimal" or "base 10," is the standard number system used around the world. Therefore, make use of it.
Change-Id: Ia22705d7629a322292cfd557add9cfadc649c16c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37537 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/apple/macbook21/hda_verb.c M src/mainboard/apple/macbookair4_2/hda_verb.c M src/mainboard/asrock/b75pro3-m/hda_verb.c M src/mainboard/asrock/h110m/hda_verb.c M src/mainboard/asus/p8h61-m_pro/hda_verb.c M src/mainboard/asus/p8z77-m_pro/hda_verb.c M src/mainboard/compulab/intense_pc/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c M src/mainboard/google/butterfly/hda_verb.c M src/mainboard/hp/2570p/hda_verb.c M src/mainboard/hp/2760p/hda_verb.c M src/mainboard/hp/8460p/hda_verb.c M src/mainboard/hp/8470p/hda_verb.c M src/mainboard/hp/8770w/hda_verb.c M src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c M src/mainboard/hp/folio_9470m/hda_verb.c M src/mainboard/hp/revolve_810_g1/hda_verb.c M src/mainboard/hp/z220_sff_workstation/hda_verb.c M src/mainboard/intel/dcp847ske/hda_verb.c M src/mainboard/lenovo/l520/hda_verb.c M src/mainboard/lenovo/s230u/hda_verb.c M src/mainboard/lenovo/t410/hda_verb.c M src/mainboard/lenovo/t420/hda_verb.c M src/mainboard/lenovo/t420s/hda_verb.c M src/mainboard/lenovo/t430/hda_verb.c M src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c M src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c M src/mainboard/lenovo/t520/hda_verb.c M src/mainboard/lenovo/t530/hda_verb.c M src/mainboard/lenovo/t60/hda_verb.c M src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c M src/mainboard/lenovo/x201/hda_verb.c M src/mainboard/lenovo/x220/hda_verb.c M src/mainboard/lenovo/x230/hda_verb.c M src/mainboard/lenovo/x60/hda_verb.c M src/mainboard/msi/ms7707/hda_verb.c M src/mainboard/packardbell/ms2290/hda_verb.c M src/mainboard/sapphire/pureplatinumh61/hda_verb.c 39 files changed, 69 insertions(+), 69 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/hda_verb.c b/src/mainboard/apple/macbook21/hda_verb.c index 09d5f1a..3d87d3d 100644 --- a/src/mainboard/apple/macbook21/hda_verb.c +++ b/src/mainboard/apple/macbook21/hda_verb.c @@ -22,7 +22,7 @@ #if CONFIG(BOARD_APPLE_MACBOOK11) || \ CONFIG(BOARD_APPLE_MACBOOK21) 0x106b2200, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106B2200), @@ -58,7 +58,7 @@ AZALIA_PIN_CFG(0x0, 0x1B, 0x400000FB), #else /* CONFIG_BOARD_APPLE_IMAC52 */ 0x106b0f00, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106b0f00), diff --git a/src/mainboard/apple/macbookair4_2/hda_verb.c b/src/mainboard/apple/macbookair4_2/hda_verb.c index 6ca5f51..69a165c 100644 --- a/src/mainboard/apple/macbookair4_2/hda_verb.c +++ b/src/mainboard/apple/macbookair4_2/hda_verb.c @@ -17,7 +17,7 @@ 0x10134206, /* Codec Vendor / Device ID: Cirrus */ 0x106b5b00, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x106b5b00),
@@ -53,7 +53,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asrock/b75pro3-m/hda_verb.c b/src/mainboard/asrock/b75pro3-m/hda_verb.c index cae9137..d7e41b7 100644 --- a/src/mainboard/asrock/b75pro3-m/hda_verb.c +++ b/src/mainboard/asrock/b75pro3-m/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x18498892, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x18498892),
@@ -69,7 +69,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asrock/h110m/hda_verb.c b/src/mainboard/asrock/h110m/hda_verb.c index 2fb0fe7..6e13784 100644 --- a/src/mainboard/asrock/h110m/hda_verb.c +++ b/src/mainboard/asrock/h110m/hda_verb.c @@ -41,7 +41,7 @@ /* coreboot specific header */ 0x80862809, /* Codec Vendor / Device ID: Intel Skylake HDMI */ 0x80860101, - 0x00000004, + 4, /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x2, 0x80860101),
diff --git a/src/mainboard/asus/p8h61-m_pro/hda_verb.c b/src/mainboard/asus/p8h61-m_pro/hda_verb.c index 13b25ed..05a2b39 100644 --- a/src/mainboard/asus/p8h61-m_pro/hda_verb.c +++ b/src/mainboard/asus/p8h61-m_pro/hda_verb.c @@ -19,7 +19,7 @@ 0x10ec0887, /* Codec Vendor / Device ID: Realtek */ 0x10438444, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10438444),
@@ -67,7 +67,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/asus/p8z77-m_pro/hda_verb.c b/src/mainboard/asus/p8z77-m_pro/hda_verb.c index 4fd3fcc..1f22a7c 100644 --- a/src/mainboard/asus/p8z77-m_pro/hda_verb.c +++ b/src/mainboard/asus/p8z77-m_pro/hda_verb.c @@ -22,7 +22,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x10438436, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* Subsystem ID */ AZALIA_SUBVENDOR(0x0, 0x10438436),
@@ -43,7 +43,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* Subsystem ID */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/compulab/intense_pc/hda_verb.c b/src/mainboard/compulab/intense_pc/hda_verb.c index 5cade62..c71d83b 100644 --- a/src/mainboard/compulab/intense_pc/hda_verb.c +++ b/src/mainboard/compulab/intense_pc/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0888, /* Codec Vendor / Device ID: Realtek */ 0x10ec0888, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10ec0888),
@@ -69,7 +69,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c index 93c7e11..a0e0614 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/hda_verb.c @@ -19,7 +19,7 @@ const u32 cim_verb_data[] = { 0x10ec0887, /* Realtek ALC887 */ 0x1458a002, /* Subsystem ID */ - 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x2, 0x1458a002), AZALIA_PIN_CFG(0x2, 0x11, 0x411111f0), AZALIA_PIN_CFG(0x2, 0x12, 0x411111f0), diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c index e160538..8860993 100644 --- a/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c +++ b/src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/hda_verb.c @@ -19,7 +19,7 @@ const u32 cim_verb_data[] = { 0x10ec0887, /* Realtek ALC887 */ 0x1458a002, /* Subsystem ID */ - 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0x2, 0x1458a002), AZALIA_PIN_CFG(0x2, 0x11, 0x411110f0), AZALIA_PIN_CFG(0x2, 0x12, 0x411111f0), diff --git a/src/mainboard/google/butterfly/hda_verb.c b/src/mainboard/google/butterfly/hda_verb.c index caf8b4a..fc34e56 100644 --- a/src/mainboard/google/butterfly/hda_verb.c +++ b/src/mainboard/google/butterfly/hda_verb.c @@ -26,7 +26,7 @@ /* coreboot specific header */ 0x111D76E5, // Codec Vendor / Device ID: IDT 92HD99 0x103C18F9, // Subsystem ID - 0x00000073, // Number of 4 dword sets + 115, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -206,7 +206,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/hp/2570p/hda_verb.c b/src/mainboard/hp/2570p/hda_verb.c index 3c4c734..a8e0729 100644 --- a/src/mainboard/hp/2570p/hda_verb.c +++ b/src/mainboard/hp/2570p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c17df, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c17df),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/2760p/hda_verb.c b/src/mainboard/hp/2760p/hda_verb.c index 6a62cf1..48b730a 100644 --- a/src/mainboard/hp/2760p/hda_verb.c +++ b/src/mainboard/hp/2760p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c162a, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c162a),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/8460p/hda_verb.c b/src/mainboard/hp/8460p/hda_verb.c index 8436707..96430133 100644 --- a/src/mainboard/hp/8460p/hda_verb.c +++ b/src/mainboard/hp/8460p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c3588, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c3588),
@@ -57,7 +57,7 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), }; diff --git a/src/mainboard/hp/8470p/hda_verb.c b/src/mainboard/hp/8470p/hda_verb.c index 0d7389a..a24aeb2 100644 --- a/src/mainboard/hp/8470p/hda_verb.c +++ b/src/mainboard/hp/8470p/hda_verb.c @@ -21,7 +21,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c17c2, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c17c2),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/8770w/hda_verb.c b/src/mainboard/hp/8770w/hda_verb.c index 51869cb..cc66a31 100644 --- a/src/mainboard/hp/8770w/hda_verb.c +++ b/src/mainboard/hp/8770w/hda_verb.c @@ -22,7 +22,7 @@ 0x111d7605, /* Codec Vendor / Device ID: IDT */ 0x103c176c, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c176c),
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c b/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c index 4b90aab..907ad2f 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c +++ b/src/mainboard/hp/compaq_8200_elite_sff/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0662, /* Codec Vendor / Device ID: Realtek */ 0x103c1495, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c1495),
@@ -57,7 +57,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80861495, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80861495),
diff --git a/src/mainboard/hp/folio_9470m/hda_verb.c b/src/mainboard/hp/folio_9470m/hda_verb.c index 3abd5be..14d181f 100644 --- a/src/mainboard/hp/folio_9470m/hda_verb.c +++ b/src/mainboard/hp/folio_9470m/hda_verb.c @@ -21,7 +21,7 @@ 0x111d76e0, /* Codec Vendor / Device ID: IDT */ 0x103c18df, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c18df),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/revolve_810_g1/hda_verb.c b/src/mainboard/hp/revolve_810_g1/hda_verb.c index c7d5662..693ee40 100644 --- a/src/mainboard/hp/revolve_810_g1/hda_verb.c +++ b/src/mainboard/hp/revolve_810_g1/hda_verb.c @@ -21,7 +21,7 @@ 0x111d76e0, /* Codec Vendor / Device ID: IDT */ 0x103c18f8, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c18f8),
@@ -57,13 +57,13 @@ 0x11c11040, /* Codec Vendor / Device ID: LSI */ 0x103c3066, /* Subsystem ID */
- 0x00000001, /* Number of 4 dword sets */ + 1, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x1, 0x103c3066), 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/hp/z220_sff_workstation/hda_verb.c b/src/mainboard/hp/z220_sff_workstation/hda_verb.c index 91804c1..9ded3ec 100644 --- a/src/mainboard/hp/z220_sff_workstation/hda_verb.c +++ b/src/mainboard/hp/z220_sff_workstation/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0221, /* Codec Vendor / Device ID: Realtek */ 0x103c1791, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x103c1791),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x103c1791, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x103c1791),
diff --git a/src/mainboard/intel/dcp847ske/hda_verb.c b/src/mainboard/intel/dcp847ske/hda_verb.c index b000347..3b7190d 100644 --- a/src/mainboard/intel/dcp847ske/hda_verb.c +++ b/src/mainboard/intel/dcp847ske/hda_verb.c @@ -21,7 +21,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/l520/hda_verb.c b/src/mainboard/lenovo/l520/hda_verb.c index 30a4a61..bca06f5 100644 --- a/src/mainboard/lenovo/l520/hda_verb.c +++ b/src/mainboard/lenovo/l520/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa21de, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa21de),
@@ -57,7 +57,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/s230u/hda_verb.c b/src/mainboard/lenovo/s230u/hda_verb.c index f2da2c4..85150e5 100644 --- a/src/mainboard/lenovo/s230u/hda_verb.c +++ b/src/mainboard/lenovo/s230u/hda_verb.c @@ -22,7 +22,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x0000000c, // Number of 4 dword sets + 12, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -106,7 +106,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t410/hda_verb.c b/src/mainboard/lenovo/t410/hda_verb.c index 752e5da..2b871f6 100644 --- a/src/mainboard/lenovo/t410/hda_verb.c +++ b/src/mainboard/lenovo/t410/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x14F15069, /* Codec Vendor / Device ID: Conexant CX20585 */ 0x17AA214C, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17AA214C), AZALIA_PIN_CFG(0x0, 0x19, 0x042110F0), @@ -36,7 +36,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x17AA21B5, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x3, 0x17AA21B5), AZALIA_PIN_CFG(0x3, 0x04, 0x18560010), diff --git a/src/mainboard/lenovo/t420/hda_verb.c b/src/mainboard/lenovo/t420/hda_verb.c index 18a61a2..9287d4a 100644 --- a/src/mainboard/lenovo/t420/hda_verb.c +++ b/src/mainboard/lenovo/t420/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic show CX20672 0x17aa21ce, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t420s/hda_verb.c b/src/mainboard/lenovo/t420s/hda_verb.c index cad2050..8a9c3e5 100644 --- a/src/mainboard/lenovo/t420s/hda_verb.c +++ b/src/mainboard/lenovo/t420s/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic show CX20672 0x17aa21d2, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t430/hda_verb.c b/src/mainboard/lenovo/t430/hda_verb.c index 02f433f..255198f 100644 --- a/src/mainboard/lenovo/t430/hda_verb.c +++ b/src/mainboard/lenovo/t430/hda_verb.c @@ -55,7 +55,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c b/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c index f73434d..c5c17b8 100644 --- a/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c +++ b/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fb, // Subsystem ID - 0x00000013, // Number of 4 dword sets + 19, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -105,7 +105,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c b/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c index 179fba0..1c5d376 100644 --- a/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c +++ b/src/mainboard/lenovo/t430s/variants/t431s/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa2208, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa2208),
@@ -57,7 +57,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/t520/hda_verb.c b/src/mainboard/lenovo/t520/hda_verb.c index dae692d..2d10e35 100644 --- a/src/mainboard/lenovo/t520/hda_verb.c +++ b/src/mainboard/lenovo/t520/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 - Schematic shows CX20672 0x17aa21cf, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ diff --git a/src/mainboard/lenovo/t530/hda_verb.c b/src/mainboard/lenovo/t530/hda_verb.c index 154b314..f8876aa 100644 --- a/src/mainboard/lenovo/t530/hda_verb.c +++ b/src/mainboard/lenovo/t530/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x00000012, // Number of 4 dword sets + 18, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -104,7 +104,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/t60/hda_verb.c b/src/mainboard/lenovo/t60/hda_verb.c index 3507776..216696b 100644 --- a/src/mainboard/lenovo/t60/hda_verb.c +++ b/src/mainboard/lenovo/t60/hda_verb.c @@ -16,7 +16,7 @@ const u32 cim_verb_data[] = { 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */ 0x17aa2025, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17aa2025),
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c b/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c index 2a216d3..1946286 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c @@ -20,7 +20,7 @@ 0x10ec0269, /* Codec Vendor / Device ID: Realtek */ 0x17aa21f9, /* Subsystem ID */
- 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17aa21f9),
@@ -56,7 +56,7 @@ 0x80862806, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
diff --git a/src/mainboard/lenovo/x201/hda_verb.c b/src/mainboard/lenovo/x201/hda_verb.c index 820e2c5..25a87f5 100644 --- a/src/mainboard/lenovo/x201/hda_verb.c +++ b/src/mainboard/lenovo/x201/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x14F15069, /* Codec Vendor / Device ID: Conexant CX20585 */ 0x17AA2155, /* Subsystem ID */ - 0x0000000B, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x17AA2155), @@ -57,7 +57,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x17aa21b5, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21b5 */ AZALIA_SUBVENDOR(0x3, 0x17AA21B5), diff --git a/src/mainboard/lenovo/x220/hda_verb.c b/src/mainboard/lenovo/x220/hda_verb.c index d94c320..b7b670d 100644 --- a/src/mainboard/lenovo/x220/hda_verb.c +++ b/src/mainboard/lenovo/x220/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x14f1506e, // Codec Vendor / Device ID: Conexant CX20590 0x17aa21db, // Subsystem ID - 0x0000000d, // Number of 4 dword sets + 13, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -71,7 +71,7 @@ /* coreboot specific header */ 0x80862805, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/x230/hda_verb.c b/src/mainboard/lenovo/x230/hda_verb.c index 792579a..0393ff5 100644 --- a/src/mainboard/lenovo/x230/hda_verb.c +++ b/src/mainboard/lenovo/x230/hda_verb.c @@ -27,7 +27,7 @@ /* coreboot specific header */ 0x10ec0269, // Codec Vendor / Device ID: Realtek ALC269VC 0x17aa21fa, // Subsystem ID - 0x00000013, // Number of 4 dword sets + 19, // Number of 4 dword sets
/* Bits 31:28 - Codec Address */ /* Bits 27:20 - NID */ @@ -112,7 +112,7 @@ /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel PantherPoint HDMI 0x80860101, // Subsystem ID - 0x00000004, // Number of IDs + 4, // Number of IDs
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x80860101 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/lenovo/x60/hda_verb.c b/src/mainboard/lenovo/x60/hda_verb.c index 3507776..216696b 100644 --- a/src/mainboard/lenovo/x60/hda_verb.c +++ b/src/mainboard/lenovo/x60/hda_verb.c @@ -16,7 +16,7 @@ const u32 cim_verb_data[] = { 0x11d41981, /* Codec Vendor / Device ID: Analog Devices AD1981 */ 0x17aa2025, /* Subsystem ID */ - 0x0000000b, /* Number of 4 dword sets */ + 11, /* Number of 4 dword sets */
AZALIA_SUBVENDOR(0x0, 0x17aa2025),
diff --git a/src/mainboard/msi/ms7707/hda_verb.c b/src/mainboard/msi/ms7707/hda_verb.c index 6a6cf41..7ff2bee 100644 --- a/src/mainboard/msi/ms7707/hda_verb.c +++ b/src/mainboard/msi/ms7707/hda_verb.c @@ -21,7 +21,7 @@ 0x10ec0887, /* Codec Vendor / Device ID: Realtek */ 0x14627707, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x14627707),
diff --git a/src/mainboard/packardbell/ms2290/hda_verb.c b/src/mainboard/packardbell/ms2290/hda_verb.c index 1932ff9..d458cd6 100644 --- a/src/mainboard/packardbell/ms2290/hda_verb.c +++ b/src/mainboard/packardbell/ms2290/hda_verb.c @@ -20,7 +20,7 @@ /* coreboot specific header */ 0x10ec0272, /* Codec Vendor / Device ID: Realtek ALC272X */ 0x10250379, /* Subsystem ID */ - 0x00000006, /* Number of 4 dword sets */ + 6, /* Number of 4 dword sets */
/* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x0, 0x10250379), @@ -42,7 +42,7 @@
0x80862804, /* Codec Vendor / Device ID: Intel Ibexpeak HDMI. */ 0x80860101, /* Subsystem ID */ - 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x17aa21b5 */ AZALIA_SUBVENDOR(0x3, 0x80860101), diff --git a/src/mainboard/sapphire/pureplatinumh61/hda_verb.c b/src/mainboard/sapphire/pureplatinumh61/hda_verb.c index cf723d0..9be242e 100644 --- a/src/mainboard/sapphire/pureplatinumh61/hda_verb.c +++ b/src/mainboard/sapphire/pureplatinumh61/hda_verb.c @@ -20,7 +20,7 @@ 0x10ec0892, /* Codec Vendor / Device ID: Realtek */ 0x10ec0000, /* Subsystem ID */
- 0x0000000f, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x2, 0x10ec0000),
@@ -68,7 +68,7 @@ 0x80862805, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */
- 0x00000004, /* Number of 4 dword sets */ + 4, /* Number of 4 dword sets */ /* NID 0x01: Subsystem ID. */ AZALIA_SUBVENDOR(0x3, 0x80860101),
-
Angel Pons (Code Review) -
Evgeny Zinoviev (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)