Attention is currently required from: Jason Glenesk, Marshall Dawson, Julian Schroeder, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY
......................................................................
Patch Set 1:
(3 comments)
File src/vendorcode/amd/fsp/cezanne/FspUsb.h:
https://review.coreboot.org/c/coreboot/+/54065/comment/27c3d85d_f42916f8
PS1, Line 10: #if 0
?
https://review.coreboot.org/c/coreboot/+/54065/comment/c6e91209_4135cf30
PS1, Line 44: compdstune
Is there documentation that could be added to these? Or maybe we can define some enums?
https://review.coreboot.org/c/coreboot/+/54065/comment/e8eb64fb_59365680
PS1, Line 67:
nit: indenting
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I011ca40a334e4fd26778ca7f18b653298b14019b
Gerrit-Change-Number: 54065
Gerrit-PatchSet: 1
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 11 May 2021 16:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment