Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81253?usp=email )
Change subject: amdfwtool: Move the header creation into integration function
......................................................................
Patch Set 3:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81253/comment/193af170_ab1c49a6 :
PS2, Line 963: else if (ctx->pspdir2_b == NULL)
i'd use else if (cookie == PSPL2_COOKIE && ctx->pspdir2_b == NULL) to properly handle the case of an […]
Done
https://review.coreboot.org/c/coreboot/+/81253/comment/ac542876_268ff627 :
PS2, Line 1260: else if (ctx->biosdir2_b == NULL)
i'd check for cookie == BHDL2_COOKIE && ctx->biosdir2_b == NULL to also cover the case of an unexpec […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9d78bb8145855203048208fcd67f8b9cd9d3199
Gerrit-Change-Number: 81253
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment