Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
security/tpm: Use SPDX identifiers
Change-Id: I22001320f2ce1f0db348e0f7fabc5a65b50ba53e Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_internal.h M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/security/tpm/tss/vendor/cr50/cr50.c M src/security/tpm/tss_errors.h 10 files changed, 13 insertions(+), 49 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/41600/1
diff --git a/src/security/tpm/tss.h b/src/security/tpm/tss.h index 57f3b24..f644e3e 100644 --- a/src/security/tpm/tss.h +++ b/src/security/tpm/tss.h @@ -1,8 +1,4 @@ -/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. - * Copyright (C) 2018-2019 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
/* * TPM Lightweight Command Library. diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index ea3f94d..92ca1bd 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -1,7 +1,4 @@ -/* Copyright (c) 2012 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
/* A lightweight TPM command library. * diff --git a/src/security/tpm/tss/tcg-1.2/tss_internal.h b/src/security/tpm/tss/tcg-1.2/tss_internal.h index e999cb9..1f49f04 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_internal.h +++ b/src/security/tpm/tss/tcg-1.2/tss_internal.h @@ -1,7 +1,4 @@ -/* Copyright (c) 2010 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#ifndef TCG_TSS_INTERNAL_H_ #define TCG_TSS_INTERNAL_H_ diff --git a/src/security/tpm/tss/tcg-1.2/tss_structures.h b/src/security/tpm/tss/tcg-1.2/tss_structures.h index 50fa3fb..5db91c9 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_structures.h +++ b/src/security/tpm/tss/tcg-1.2/tss_structures.h @@ -1,8 +1,6 @@ -/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - * - * Some TPM constants and type definitions for standalone compilation for use +/* SPDX-License-Identifier: BSD-3-Clause */ + +/* Some TPM constants and type definitions for standalone compilation for use * in the firmware */ #ifndef TCG1_TSS_STRUCTURES_H_ diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index 49a6cea..79d8eb9 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -1,9 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Copyright 2017-2019 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <console/console.h> #include <endian.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index eff1acd..f31c7d0 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -1,9 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Copyright (c) 2018 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <commonlib/iobuf.h> #include <console/console.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.h b/src/security/tpm/tss/tcg-2.0/tss_marshaling.h index d34756d..432cf5a3 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.h +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.h @@ -1,8 +1,5 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */ + #ifndef TCG2_TSS_MARSHALING_H_ #define TCG2_TSS_MARSHALING_H_
diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index 3f0c654..f8c6012 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -1,8 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#ifndef TCG2_TSS_STRUCTURES_H_ #define TCG2_TSS_STRUCTURES_H_ diff --git a/src/security/tpm/tss/vendor/cr50/cr50.c b/src/security/tpm/tss/vendor/cr50/cr50.c index d7bf48d..3be1e5a 100644 --- a/src/security/tpm/tss/vendor/cr50/cr50.c +++ b/src/security/tpm/tss/vendor/cr50/cr50.c @@ -1,8 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <console/console.h> #include <endian.h> diff --git a/src/security/tpm/tss_errors.h b/src/security/tpm/tss_errors.h index ed6fc3d..bdcfbbf 100644 --- a/src/security/tpm/tss_errors.h +++ b/src/security/tpm/tss_errors.h @@ -1,7 +1,4 @@ -/* Copyright (c) 2010 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
/* TPM error codes. *
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h@3 PS1, Line 3: /* : * TPM Lightweight Command Library. : * : * A low-level library for interfacing to TPM hardware or an emulator. : */ What's the correct style for a file-level comment in coreboot? Some files have:
/* blah blah * blah blah */
And some have:
/* * blah blah * blah blah */
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h@3 PS1, Line 3: /* : * TPM Lightweight Command Library. : * : * A low-level library for interfacing to TPM hardware or an emulator. : */
What's the correct style for a file-level comment in coreboot? Some files have: […]
From the style guide, I think the two preferred options are
/* blah blah blah blah */
or
/* * blah blah * blah blah */
though there doesn't seem to be much consistency with this.
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h@3 PS1, Line 3: /* : * TPM Lightweight Command Library. : * : * A low-level library for interfacing to TPM hardware or an emulator. : */
From the style guide, I think the two preferred options are […]
^^ Indeed. Any chance you could update the files in this CL to use style #2 of the above? I think we just need an extra line break in a few spots...
Hello build bot (Jenkins), Joel Kitching, Patrick Georgi, Martin Roth, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41600
to look at the new patch set (#2).
Change subject: security/tpm: Use SPDX identifiers ......................................................................
security/tpm: Use SPDX identifiers
Also adjust a few comments to follow the style guide.
Change-Id: I22001320f2ce1f0db348e0f7fabc5a65b50ba53e Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_internal.h M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/security/tpm/tss/vendor/cr50/cr50.c M src/security/tpm/tss_errors.h 10 files changed, 19 insertions(+), 51 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/41600/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h@3 PS1, Line 3: /* : * TPM Lightweight Command Library. : * : * A low-level library for interfacing to TPM hardware or an emulator. : */
^^ Indeed. […]
Done
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/2/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/2/src/security/tpm/tss.h@1 PS2, Line 1: BSD-3-Clause Need to retain the copyright notices: CB:41222
Same for all files
Hello build bot (Jenkins), Joel Kitching, Patrick Georgi, Martin Roth, Julius Werner, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41600
to look at the new patch set (#3).
Change subject: security/tpm: Use SPDX identifiers ......................................................................
security/tpm: Use SPDX identifiers
Also adjust a few comments to follow the style guide.
Change-Id: I22001320f2ce1f0db348e0f7fabc5a65b50ba53e Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M LICENSES/retained-copyrights.txt M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_internal.h M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/security/tpm/tss/vendor/cr50/cr50.c M src/security/tpm/tss_errors.h 11 files changed, 23 insertions(+), 51 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/41600/3
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/2/src/security/tpm/tss.h File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/2/src/security/tpm/tss.h@1 PS2, Line 1: BSD-3-Clause
Need to retain the copyright notices: CB:41222 […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
security/tpm: Use SPDX identifiers
Also adjust a few comments to follow the style guide.
Change-Id: I22001320f2ce1f0db348e0f7fabc5a65b50ba53e Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/41600 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M LICENSES/retained-copyrights.txt M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-1.2/tss_internal.h M src/security/tpm/tss/tcg-1.2/tss_structures.h M src/security/tpm/tss/tcg-2.0/tss.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.h M src/security/tpm/tss/tcg-2.0/tss_structures.h M src/security/tpm/tss/vendor/cr50/cr50.c M src/security/tpm/tss_errors.h 11 files changed, 23 insertions(+), 51 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/LICENSES/retained-copyrights.txt b/LICENSES/retained-copyrights.txt index 671f37f..066bf6f 100644 --- a/LICENSES/retained-copyrights.txt +++ b/LICENSES/retained-copyrights.txt @@ -11,6 +11,7 @@ Copyright 2015, Google Inc. Copyright 2016 Jonathan Neuschäfer j.neuschaefer@gmx.net Copyright 2016 The Chromium OS Authors. All rights reserved. +Copyright 2017-2019 Eltan B.V. Copyright 2017 Google Inc. Copyright 2018 Generated Code Copyright 2018-present Facebook, Inc. @@ -32,6 +33,7 @@ Copyright (c) 2010, Code Aurora Forum. All rights reserved. Copyright (C) 2010 coresystems GmbH Copyright (c) 2010 Per Odlund per.odlund@armagedon.se +Copyright (c) 2010 The Chromium OS Authors. All rights reserved. Copyright (c) 2011-2012, Code Aurora Forum. All rights reserved. Copyright (c) 2011-2012 The Linux Foundation. All rights reserved. Copyright (c) 2011-2012, The Linux Foundation. All rights reserved. @@ -79,7 +81,9 @@ Copyright (c) 2016, 2018, The Linux Foundation. All rights reserved. Copyright (C) 2016 Google Inc. Copyright (c) 2016, The Regents of the University of California (Regents). +Copyright (C) 2018-2019 Eltan B.V. Copyright (C) 2018 - 2019 The Linux Foundation. All rights reserved. +Copyright (c) 2018 Eltan B.V. Copyright (c) 2018, HardenedLinux. Copyright (C) 2018, The Linux Foundation. All rights reserved. Copyright Dave Airlie airlied@redhat.com diff --git a/src/security/tpm/tss.h b/src/security/tpm/tss.h index 57f3b24..f644e3e 100644 --- a/src/security/tpm/tss.h +++ b/src/security/tpm/tss.h @@ -1,8 +1,4 @@ -/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. - * Copyright (C) 2018-2019 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
/* * TPM Lightweight Command Library. diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index ea3f94d..4434ca6 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -1,9 +1,7 @@ -/* Copyright (c) 2012 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
-/* A lightweight TPM command library. +/* + * A lightweight TPM command library. * * The general idea is that TPM commands are array of bytes whose * fields are mostly compile-time constant. The goal is to build much @@ -75,7 +73,8 @@ return tpm_command_code(buffer); }
-/* Like TlclSendReceive below, but do not retry if NEEDS_SELFTEST or +/* + * Like TlclSendReceive below, but do not retry if NEEDS_SELFTEST or * DOING_SELFTEST errors are returned. */ static uint32_t tlcl_send_receive_no_retry(const uint8_t *request, diff --git a/src/security/tpm/tss/tcg-1.2/tss_internal.h b/src/security/tpm/tss/tcg-1.2/tss_internal.h index e999cb9..1f49f04 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_internal.h +++ b/src/security/tpm/tss/tcg-1.2/tss_internal.h @@ -1,7 +1,4 @@ -/* Copyright (c) 2010 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#ifndef TCG_TSS_INTERNAL_H_ #define TCG_TSS_INTERNAL_H_ diff --git a/src/security/tpm/tss/tcg-1.2/tss_structures.h b/src/security/tpm/tss/tcg-1.2/tss_structures.h index 50fa3fb..4a976c8 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_structures.h +++ b/src/security/tpm/tss/tcg-1.2/tss_structures.h @@ -1,7 +1,6 @@ -/* Copyright (c) 2013 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - * +/* SPDX-License-Identifier: BSD-3-Clause */ + +/* * Some TPM constants and type definitions for standalone compilation for use * in the firmware */ diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index 49a6cea..79d8eb9 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -1,9 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Copyright 2017-2019 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <console/console.h> #include <endian.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index eff1acd..f31c7d0 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -1,9 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Copyright (c) 2018 Eltan B.V. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <commonlib/iobuf.h> #include <console/console.h> diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.h b/src/security/tpm/tss/tcg-2.0/tss_marshaling.h index d34756d..432cf5a3 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.h +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.h @@ -1,8 +1,5 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */ + #ifndef TCG2_TSS_MARSHALING_H_ #define TCG2_TSS_MARSHALING_H_
diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index 3f0c654..f8c6012 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -1,8 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#ifndef TCG2_TSS_STRUCTURES_H_ #define TCG2_TSS_STRUCTURES_H_ diff --git a/src/security/tpm/tss/vendor/cr50/cr50.c b/src/security/tpm/tss/vendor/cr50/cr50.c index d7bf48d..3be1e5a 100644 --- a/src/security/tpm/tss/vendor/cr50/cr50.c +++ b/src/security/tpm/tss/vendor/cr50/cr50.c @@ -1,8 +1,4 @@ -/* - * Copyright 2016 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
#include <console/console.h> #include <endian.h> diff --git a/src/security/tpm/tss_errors.h b/src/security/tpm/tss_errors.h index ed6fc3d..7c4e569 100644 --- a/src/security/tpm/tss_errors.h +++ b/src/security/tpm/tss_errors.h @@ -1,9 +1,7 @@ -/* Copyright (c) 2010 The Chromium OS Authors. All rights reserved. - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ +/* SPDX-License-Identifier: BSD-3-Clause */
-/* TPM error codes. +/* + * TPM error codes. * * Copy-pasted and lightly edited from TCG TPM Main Part 2 TPM Structures * Version 1.2 Level 2 Revision 103 26 October 2006 Draft.
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3942 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3941 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3940 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3939
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Jacob Garber (Code Review)
-
Joel Kitching (Code Review)