Attention is currently required from: Raul Rangel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59550 )
Change subject: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP ......................................................................
Patch Set 1:
(1 comment)
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/59550/comment/cb5fc146_9247d43f PS1, Line 306: ENV_ROMSTAGE
I just had another thought. This ENV_ is for COOP and not CBFS. […]
I don't think it's a good idea to try to check if it was still the same device afterwards... that would just turn into a mess. It's also not really helpful, we don't want anything to preload data that it needs to throw away later, that's just a waste of time, we'd want to ensure it doesn't try to preload anything to begin with in that case.
I agree it doesn't really belong here though, putting it in cbfs_preload() sounds good.
-
Julius Werner (Code Review)