HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34439 )
Change subject: device: Fix naked reference to CONFIG_DEBUG_RAM_SETUP ......................................................................
device: Fix naked reference to CONFIG_DEBUG_RAM_SETUP
Found-by: util/lint/kconfig_lint Change-Id: I360c4f563c2aa2acc740eac6c4e0145bda18edb7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/include/device/dram/common.h M src/include/device/dram/ddr3.h 4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/34439/1
diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 60588b8..eec2d74 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -668,8 +668,8 @@ /** * \brief Print the info in DIMM * -* Print info about the DIMM. Useful to use when CONFIG_DEBUG_RAM_SETUP is -* selected, or for a purely informative output. +* Print info about the DIMM. Useful to use when CONFIG(DEBUG_RAM_SETUP) is +* true, or for a purely informative output. * * @param dimm pointer to already decoded @ref dimm_attr structure */ diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c index 834dc83..8d79710 100644 --- a/src/device/dram/ddr3.c +++ b/src/device/dram/ddr3.c @@ -624,8 +624,8 @@ /** * \brief Print the info in DIMM * -* Print info about the DIMM. Useful to use when CONFIG_DEBUG_RAM_SETUP is -* selected, or for a purely informative output. +* Print info about the DIMM. Useful to use when CONFIG(DEBUG_RAM_SETUP) is +* true, or for a purely informative output. * * @param dimm pointer to already decoded @ref dimm_attr structure */ diff --git a/src/include/device/dram/common.h b/src/include/device/dram/common.h index b1677c8..7be58ab 100644 --- a/src/include/device/dram/common.h +++ b/src/include/device/dram/common.h @@ -45,10 +45,10 @@ /** @} */
/** - * \brief Convenience macro for enabling printk with CONFIG_DEBUG_RAM_SETUP + * \brief Convenience macro for enabling printk with CONFIG(DEBUG_RAM_SETUP) * * Use this macro instead of printk(); for verbose RAM initialization messages. - * When CONFIG_DEBUG_RAM_SETUP is not selected, these messages are automatically + * When CONFIG(DEBUG_RAM_SETUP) is not selected, these messages are automatically * disabled. * @{ */ diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h index 0f9373e..19bce96 100644 --- a/src/include/device/dram/ddr3.h +++ b/src/include/device/dram/ddr3.h @@ -49,10 +49,10 @@ /** @} */
/** - * \brief Convenience macro for enabling printk with CONFIG_DEBUG_RAM_SETUP + * \brief Convenience macro for enabling printk with CONFIG(DEBUG_RAM_SETUP) * * Use this macro instead of printk(); for verbose RAM initialization messages. - * When CONFIG_DEBUG_RAM_SETUP is not selected, these messages are automatically + * When CONFIG(DEBUG_RAM_SETUP) is false, these messages are automatically * disabled. * @{ */
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34439 )
Change subject: device: Fix naked reference to CONFIG_DEBUG_RAM_SETUP ......................................................................
Abandoned