Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
mb/intel/d510mo: Add vbt file
Add vbt file extracted from the vendor UEFI blob.
Change-Id: Idd39065e9cf5a420317d79695cf032713173eeab Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/intel/d510mo/Kconfig A src/mainboard/intel/d510mo/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/39880/1
diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index 738eabc..c7d7de0 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -28,6 +28,7 @@ select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select DRIVERS_I2C_CK505 + select INTEL_GMA_HAVE_VBT
config MAX_CPUS int diff --git a/src/mainboard/intel/d510mo/data.vbt b/src/mainboard/intel/d510mo/data.vbt new file mode 100644 index 0000000..7cf261d --- /dev/null +++ b/src/mainboard/intel/d510mo/data.vbt Binary files differ
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39880/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39880/1//COMMIT_MSG@9 PS1, Line 9: Add vbt file extracted from the vendor UEFI blob. Which version?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39880
to look at the new patch set (#2).
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
mb/intel/d510mo: Add vbt file
Add vbt file extracted from the vendor UEFI blob version 0524.
Change-Id: Idd39065e9cf5a420317d79695cf032713173eeab Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/intel/d510mo/Kconfig A src/mainboard/intel/d510mo/data.vbt A src/mainboard/intel/minnowmax/Kconfig A src/mainboard/intel/minnowmax/Kconfig.name A src/mainboard/intel/minnowmax/Makefile.inc A src/mainboard/intel/minnowmax/acpi/ec.asl A src/mainboard/intel/minnowmax/acpi/mainboard.asl A src/mainboard/intel/minnowmax/acpi/superio.asl A src/mainboard/intel/minnowmax/acpi_tables.c A src/mainboard/intel/minnowmax/board_info.txt A src/mainboard/intel/minnowmax/cmos.layout A src/mainboard/intel/minnowmax/devicetree.cb A src/mainboard/intel/minnowmax/dsdt.asl A src/mainboard/intel/minnowmax/fadt.c A src/mainboard/intel/minnowmax/gpio.c A src/mainboard/intel/minnowmax/irqroute.c A src/mainboard/intel/minnowmax/irqroute.h A src/mainboard/intel/minnowmax/mainboard.c A src/mainboard/intel/minnowmax/romstage.c 19 files changed, 908 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/39880/2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39880/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39880/1//COMMIT_MSG@9 PS1, Line 9: Add vbt file extracted from the vendor UEFI blob.
Which version?
Done
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39880/2/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/irqroute.h:
https://review.coreboot.org/c/coreboot/+/39880/2/src/mainboard/intel/minnowm... PS2, Line 49: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39880/2/src/mainboard/intel/minnowm... PS2, Line 73: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39880
to look at the new patch set (#3).
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
mb/intel/d510mo: Add vbt file
Add vbt file extracted from the vendor UEFI blob version 0524.
Change-Id: Idd39065e9cf5a420317d79695cf032713173eeab Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/intel/d510mo/Kconfig A src/mainboard/intel/d510mo/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/39880/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 3: Code-Review+1
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 3: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
mb/intel/d510mo: Add vbt file
Add vbt file extracted from the vendor UEFI blob version 0524.
Change-Id: Idd39065e9cf5a420317d79695cf032713173eeab Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/39880 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/intel/d510mo/Kconfig A src/mainboard/intel/d510mo/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index 738eabc..c7d7de0 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -28,6 +28,7 @@ select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select DRIVERS_I2C_CK505 + select INTEL_GMA_HAVE_VBT
config MAX_CPUS int diff --git a/src/mainboard/intel/d510mo/data.vbt b/src/mainboard/intel/d510mo/data.vbt new file mode 100644 index 0000000..7cf261d --- /dev/null +++ b/src/mainboard/intel/d510mo/data.vbt Binary files differ
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39880 )
Change subject: mb/intel/d510mo: Add vbt file ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2188 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2187 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2186
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Arthur Heymans (Code Review)
-
build bot (Jenkins) (Code Review)
-
Felix Singer (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)