Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19717 )
Change subject: nb/intel/ivybridge: Improve CAS freq selection ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/19717/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_ivy.c:
Line 327: ctrl->tCK = 0;
Please set `base_freq` too, to make it clear that the recursion breaks.
ok.
Line 349: ref_100mhz_support ? "yes" : "no");
This is now printed everytime this gets called. Why not keep the
ok
Line 366: ivb_normalize_tclk(ctrl, ref_100mhz_support);
What happens after this line?
hmm it should not normalise since this is done at the beginning of the loop...
I'll add a comment to clarify the code flow
PS1, Line 373: (1000 << 8)
This should be a defined value...
ok
-
Arthur Heymans (Code Review)