Andrey Petrov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40918 )
Change subject: mb/intel/cedarisland_crb: Enable P2SB device ......................................................................
mb/intel/cedarisland_crb: Enable P2SB device
Enable P2SB in static device tree so that hide/unhide trick works.
Change-Id: I7dc20b001605b715155d333a07580e21a5f24136 Signed-off-by: Andrey Petrov anpetrov@fb.com --- M src/mainboard/intel/cedarisland_crb/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/40918/1
diff --git a/src/mainboard/intel/cedarisland_crb/devicetree.cb b/src/mainboard/intel/cedarisland_crb/devicetree.cb index 6eb9557..6de9091 100644 --- a/src/mainboard/intel/cedarisland_crb/devicetree.cb +++ b/src/mainboard/intel/cedarisland_crb/devicetree.cb @@ -28,10 +28,12 @@ device pci 17.0 on end device pci 1c.0 on end device pci 1c.4 on end + device pci 1f.1 on end device pci 1f.2 on end device pci 1f.4 on end device pci 1f.5 on end
+ device pci 1f.0 on # LPC/eSPI Interface chip superio/common device pnp 2e.0 on
Andrey Petrov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40918 )
Change subject: mb/intel/cedarisland_crb: Enable P2SB device ......................................................................
mb/intel/cedarisland_crb: Enable P2SB device
Enable P2SB in static device tree so that hide/unhide trick works.
Change-Id: I7dc20b001605b715155d333a07580e21a5f24136 Signed-off-by: Andrey Petrov anpetrov@fb.com --- M src/mainboard/intel/cedarisland_crb/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/40918/2
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40918 )
Change subject: mb/intel/cedarisland_crb: Enable P2SB device ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40918 )
Change subject: mb/intel/cedarisland_crb: Enable P2SB device ......................................................................
Patch Set 2: Code-Review+2
Andrey Petrov has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40918 )
Change subject: mb/intel/cedarisland_crb: Enable P2SB device ......................................................................
mb/intel/cedarisland_crb: Enable P2SB device
Enable P2SB in static device tree so that hide/unhide trick works.
Change-Id: I7dc20b001605b715155d333a07580e21a5f24136 Signed-off-by: Andrey Petrov anpetrov@fb.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40918 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/cedarisland_crb/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Maxim Polyakov: Looks good to me, approved
diff --git a/src/mainboard/intel/cedarisland_crb/devicetree.cb b/src/mainboard/intel/cedarisland_crb/devicetree.cb index 6eb9557..a82f022 100644 --- a/src/mainboard/intel/cedarisland_crb/devicetree.cb +++ b/src/mainboard/intel/cedarisland_crb/devicetree.cb @@ -28,10 +28,10 @@ device pci 17.0 on end device pci 1c.0 on end device pci 1c.4 on end + device pci 1f.1 on end device pci 1f.2 on end device pci 1f.4 on end device pci 1f.5 on end - device pci 1f.0 on # LPC/eSPI Interface chip superio/common device pnp 2e.0 on
-
Andrey Petrov (Code Review) -
Angel Pons (Code Review)
-
Maxim Polyakov (Code Review)