Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: Add type-c info to coreboot table
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/98bac272_7f74d27c
PS7, Line 99: {
Somewhere you'll need to allocate an entry in CBMEM for this: […]
Another pseudocode on similar lines here: https://review.coreboot.org/c/coreboot/+/57345/5..7/src/drivers/intel/pmc_mu...
The only major difference is adding port_count to `struct type_c_info` itself so that you don't have to maintain a separate ports_written variable in this function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic56a1ad1b617e3af000664147d21165e6ea3a742
Gerrit-Change-Number: 57345
Gerrit-PatchSet: 7
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 29 Sep 2021 01:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment