Change in coreboot[master]: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

[WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK

GEVENT_MASK should cover all GEVENT pins, but was missing
SMITYPE_G_AGPIO9 and SMITYPE_G_AGPIO8.

TODO: Find out if this is intentional or a bug.

Change-Id: Ia676476e2d2cf468d82d6d90e9fc11d34f56f153
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/include/soc/smi.h
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48483/1

diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h
index ad7edbc..e86809e 100644
--- a/src/soc/amd/picasso/include/soc/smi.h
+++ b/src/soc/amd/picasso/include/soc/smi.h
@@ -64,7 +64,9 @@
    	   | (1 << SMITYPE_G_FANIN0)		\
    	   | (1 << SMITYPE_G_SYSRESET_L)	\
    	   | (1 << SMITYPE_G_AGPIO40)		\
-		   | (1 << SMITYPE_G_PWR_BTN_L))
+		   | (1 << SMITYPE_G_PWR_BTN_L)		\
+		   | (1 << SMITYPE_G_AGPIO9)		\
+		   | (1 << SMITYPE_G_AGPIO8))
 #define SMITYPE_MP2_WAKE		24
 #define SMITYPE_MP2_GPIO0		25
 #define SMITYPE_ESPI_SYS		26

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

Patch Set 1:

I'm not 100% certain about this, but those two missing at least looks odd and i didn't find a reason to exclude those

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG@12 
PS1, Line 12: TODO: Find out if this is intentional or a bug.
I think this was either an oversight or these bits didn't exist in stoney where this code originated.

If you wanted, you could go back and check stoney, and if they weren't there you could surround them with a #ifndef config_soc_amd_stoney.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG@12 
PS1, Line 12: TODO: Find out if this is intentional or a bug.
> I think this was either an oversight or these bits didn't exist in stoney where this code originated […]

ok, i'll remove the [WIP] tag then. the header file is in the picasso directory, so no need to #ifndef it. Quite a few defines are identical, but i'll keep the header files separate for now

Change in coreboot[master]: soc/amd/picasso/smi: add missing bits to GEVENT_MASK

[Felix Held (Code Review)]

Hello build bot (Jenkins), Jason Glenesk, Martin Roth, Marshall Dawson,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48483

to look at the new patch set (#2).

Change subject: soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

soc/amd/picasso/smi: add missing bits to GEVENT_MASK

GEVENT_MASK should cover all GEVENT pins, but was missing
SMITYPE_G_AGPIO9 and SMITYPE_G_AGPIO8.

Change-Id: Ia676476e2d2cf468d82d6d90e9fc11d34f56f153
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/include/soc/smi.h
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48483/2

Change in coreboot[master]: soc/amd/picasso/smi: add missing bits to GEVENT_MASK

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: soc/amd/picasso/smi: add missing bits to GEVENT_MASK

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48483 )

Change subject: soc/amd/picasso/smi: add missing bits to GEVENT_MASK
......................................................................

soc/amd/picasso/smi: add missing bits to GEVENT_MASK

GEVENT_MASK should cover all GEVENT pins, but was missing
SMITYPE_G_AGPIO9 and SMITYPE_G_AGPIO8.

Change-Id: Ia676476e2d2cf468d82d6d90e9fc11d34f56f153
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48483
Tested-by: build bot (Jenkins) 
Reviewed-by: Raul Rangel 
---
M src/soc/amd/picasso/include/soc/smi.h
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved

diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h
index ad7edbc..e86809e 100644
--- a/src/soc/amd/picasso/include/soc/smi.h
+++ b/src/soc/amd/picasso/include/soc/smi.h
@@ -64,7 +64,9 @@
    	   | (1 << SMITYPE_G_FANIN0)		\
    	   | (1 << SMITYPE_G_SYSRESET_L)	\
    	   | (1 << SMITYPE_G_AGPIO40)		\
-		   | (1 << SMITYPE_G_PWR_BTN_L))
+		   | (1 << SMITYPE_G_PWR_BTN_L)		\
+		   | (1 << SMITYPE_G_AGPIO9)		\
+		   | (1 << SMITYPE_G_AGPIO8))
 #define SMITYPE_MP2_WAKE		24
 #define SMITYPE_MP2_GPIO0		25
 #define SMITYPE_ESPI_SYS		26