Maximilian Brune has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87204?usp=email )
Change subject: doc/internals/devicetree_language: eSPI doesn't support legacy DRQ ......................................................................
doc/internals/devicetree_language: eSPI doesn't support legacy DRQ
In contracts to the ISA and LPC bus, eSPI doesn't support legacy ISA-style DMA any more, so don't list eSPI as interface in the 'drq' chapter.
The Intel document #841685 "Enhanced Serial Peripheral Interface (eSPI) Interface Base Specification (for Client and Server Platforms)" revision 1.6 says this about the eSPI interface: "However, 8237 DMA and Firmware Hub (FWH) are not supported over this interface."
Change-Id: I69d4b09688699dfc984a42671abfe3804d30ade9 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/87204 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de --- M Documentation/internals/devicetree_language.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Maximilian Brune: Looks good to me, approved
diff --git a/Documentation/internals/devicetree_language.md b/Documentation/internals/devicetree_language.md index 0609559..d189844 100644 --- a/Documentation/internals/devicetree_language.md +++ b/Documentation/internals/devicetree_language.md @@ -444,7 +444,7 @@ * Usage: `drq 0x<register #> = <drq line>`
Drq is used to configure a legacy DMA Request line register for a device -on a legacy bus - ISA/LPC/eSPI. +on a legacy bus - ISA/LPC.
The drq configuration is only allowed inside a pnp block.