Attention is currently required from: Jakub Czapiga, Marek Maślanka, Subrata Banik.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/546279da_8370cc53 :
PS9, Line 406: tco_get_timer_max_value() * tco_get_timer_period() / 1000;
I think this code should be protected against overflow with u64 used for calculations before assigni […]
The max_count field per the WDAT spec is:
```
Contains the maximum counter value that this watchdog implementation supports (in count intervals).
```
So shouldn't this field be equal to TCO_TMR_MASK?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf7971f8407920a553fd91d2ed04193c882e08f1
Gerrit-Change-Number: 79909
Gerrit-PatchSet: 9
Gerrit-Owner: Marek Maślanka
mmaslanka@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Marek Maślanka
mmaslanka@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 25 Jan 2024 13:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Gerrit-MessageType: comment