Attention is currently required from: Damien Zammit, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56019 )
Change subject: nb/intel/x4x: Prepare for x86_64 support
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/x4x/raminit_ddr23.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123204):
https://review.coreboot.org/c/coreboot/+/56019/comment/bd312bee_17cf1b0b
PS2, Line 2093: read32((u32 *)(uintptr_t)(test_address(ch, r) | 0x800000 | (bank << 12)));
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id44eeb7660d0b521a326a5b981c04c16cf0a6f84
Gerrit-Change-Number: 56019
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 10:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment