Attention is currently required from: TimLiu-SMCI, Johnny Lin, David Hendricks, Christian Walter, Jian-Ming Wang, Arthur Heymans, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72611 )
Change subject: soc/intel/xeon_sp: add MSR definition for SPR-SP
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/xeon_sp/include/soc/msr.h:
https://review.coreboot.org/c/coreboot/+/72611/comment/320c0e99_a9ca2ecf
PS1, Line 44: #if (CONFIG(SOC_INTEL_SAPPHIRERAPIDS_SP))
Agreed. […]
skx/cpx/spr have different include path for <skx|cpx|spr>/include/soc.Therefore, we could have files with same file name (soc_msr.h) in those directories. And then mer.h just need to have one line:
#include <soc/soc_msr.h>
and the rest of the definitions are common for all xeon_sp socs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f2d8ac85d9fb1e75d51ad7b5fe5d9152900fc3b
Gerrit-Change-Number: 72611
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sun, 05 Feb 2023 05:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-MessageType: comment