HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41287 )
Change subject: mb/google/dragonegg: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/dragonegg: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I09b0cc8de38d65b59673de05710a581b8b517e8a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c 4 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/41287/1
diff --git a/src/mainboard/google/dragonegg/bootblock.c b/src/mainboard/google/dragonegg/bootblock.c index 22d63b9..6e1e984 100644 --- a/src/mainboard/google/dragonegg/bootblock.c +++ b/src/mainboard/google/dragonegg/bootblock.c @@ -2,7 +2,7 @@
#include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
void bootblock_mainboard_init(void) diff --git a/src/mainboard/google/dragonegg/chromeos.c b/src/mainboard/google/dragonegg/chromeos.c index 5a7efef..3795723 100644 --- a/src/mainboard/google/dragonegg/chromeos.c +++ b/src/mainboard/google/dragonegg/chromeos.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h> diff --git a/src/mainboard/google/dragonegg/mainboard.c b/src/mainboard/google/dragonegg/mainboard.c index 90889ae..c6fa728 100644 --- a/src/mainboard/google/dragonegg/mainboard.c +++ b/src/mainboard/google/dragonegg/mainboard.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <device/device.h> #include <ec/ec.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/gpio.h>
diff --git a/src/mainboard/google/dragonegg/smihandler.c b/src/mainboard/google/dragonegg/smihandler.c index 59e7001..895327d 100644 --- a/src/mainboard/google/dragonegg/smihandler.c +++ b/src/mainboard/google/dragonegg/smihandler.c @@ -3,7 +3,6 @@ #include <cpu/x86/smm.h> #include <ec/google/chromeec/smm.h> #include <gpio.h> -#include <soc/gpio.h> #include <intelblocks/smihandler.h> #include <variant/ec.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41287 )
Change subject: mb/google/dragonegg: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned