Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40383 )
Change subject: soc/intel/xeon_sp/cpx: add MADT ACPI table ......................................................................
Patch Set 15: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40383/6/src/soc/intel/xeon_sp/cpx/a... File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/40383/6/src/soc/intel/xeon_sp/cpx/a... PS6, Line 36: CBMEM_ID_CONSOLE Is this used in AML?
https://review.coreboot.org/c/coreboot/+/40383/15/src/soc/intel/xeon_sp/cpx/... File src/soc/intel/xeon_sp/cpx/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/40383/15/src/soc/intel/xeon_sp/cpx/... PS15, Line 14: acpi_create_serialio_ssdt Those seem unused and unrelated
-
Patrick Rudolph (Code Review)