Hello Kangheui Won, Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42998
to review the following change.
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
mb/google/zork: Apply cereme telemetry settings for dalboz
Currently, the telemetry settings are not for the pollock platform and might causethe power and performance issue. so applied the Pollock reference board settings to Dalboz to improve the performance, and the values need to be updated after the SDLE test finished.
BUG=b:157961590,b:152922299 BRANCH=trembyle-bringup TEST=Build.
Change-Id: I0da5b81afaa5814c13ec0257dc0eb3471be94c29 Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Kangheui Won khwon@chromium.org --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/42998/1
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index 8ac3348..587d1c5 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -17,6 +17,11 @@
# End : OPN Performance Configuration
+ register "telemetry_vddcr_vdd_slope" = "32239" #mA + register "telemetry_vddcr_vdd_offset" = "0-37" + register "telemetry_vddcr_soc_slope" = "22313" #mA + register "telemetry_vddcr_soc_offset" = "0-209" + # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42998 )
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
Patch Set 1: Code-Review+2
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42998 )
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42998/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42998/1//COMMIT_MSG@15 PS1, Line 15: BRANCH=trembyle-bringup I'm not sure how we should handle cherry picks from chromium to upstream, but I think at least it'd better to remove this line.
Chris Wang has uploaded a new patch set (#2) to the change originally created by chris wang. ( https://review.coreboot.org/c/coreboot/+/42998 )
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
mb/google/zork: Apply cereme telemetry settings for dalboz
Currently, the telemetry settings are not for the pollock platform and might causethe power and performance issue. so applied the Pollock reference board settings to Dalboz to improve the performance, and the values need to be updated after the SDLE test finished.
BUG=b:157961590,b:152922299 TEST=Build.
Change-Id: I0da5b81afaa5814c13ec0257dc0eb3471be94c29 Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Kangheui Won khwon@chromium.org --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/42998/2
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42998 )
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42998/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42998/1//COMMIT_MSG@15 PS1, Line 15: BRANCH=trembyle-bringup
I'm not sure how we should handle cherry picks from chromium to upstream, but I think at least it'd […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42998 )
Change subject: mb/google/zork: Apply cereme telemetry settings for dalboz ......................................................................
mb/google/zork: Apply cereme telemetry settings for dalboz
Currently, the telemetry settings are not for the pollock platform and might causethe power and performance issue. so applied the Pollock reference board settings to Dalboz to improve the performance, and the values need to be updated after the SDLE test finished.
BUG=b:157961590,b:152922299 TEST=Build.
Change-Id: I0da5b81afaa5814c13ec0257dc0eb3471be94c29 Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/42998 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index 8ac3348..587d1c5 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -17,6 +17,11 @@
# End : OPN Performance Configuration
+ register "telemetry_vddcr_vdd_slope" = "32239" #mA + register "telemetry_vddcr_vdd_offset" = "0-37" + register "telemetry_vddcr_soc_slope" = "22313" #mA + register "telemetry_vddcr_soc_offset" = "0-209" + # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
-
Aaron Durbin (Code Review) -
Chris Wang (Code Review)
-
chris wang (Code Review)
-
Kangheui Won (Code Review)
-
Patrick Georgi (Code Review)