Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 47:
(32 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/8fad1a92_c8d5cb8e PS47, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/e7f62e9b_17eb464d PS47, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/d65fc6ae_641172d4 PS47, Line 218: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/fb2cae7d_08731760 PS47, Line 252: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/24613629_3f06d393 PS47, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/6dd41819_36684f28 PS47, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/9a95187b_4653f8cb PS47, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/42bdb4c1_e9c8bc06 PS47, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/10f3fa6a_b1a841ef PS47, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/26b7a76c_0efbb5e7 PS47, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/4dfe1c97_b2476035 PS47, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/b2bc29a0_a9db4617 PS47, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/403b1970_00d27e05 PS47, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/25cdee78_ed2378a9 PS47, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/44050b21_6eb6fdad PS47, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/496b5f24_3d13f07c PS47, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/ad9ce094_53828c19 PS47, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/e456ccc0_6653bf2e PS47, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/0630f009_946db4a6 PS47, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/9b3c08f7_ca4339de PS47, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/426dba95_9300ab8a PS47, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/ca8240e1_86c1d159 PS47, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/429ea7bd_60bc359e PS47, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/8a4b663b_aae4a200 PS47, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/4fd8898a_26048c70 PS47, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/08d4141f_f34ec283 PS47, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/43b08504_09a03ef8 PS47, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/54f8287f_8043e805 PS47, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/03e6274b_661655bc PS47, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/f2b241cc_da492d32 PS47, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/8e4510b3_3cc62626 PS47, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159705): https://review.coreboot.org/c/coreboot/+/23586/comment/53d30834_e9e11d28 PS47, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)