Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/77682?usp=email )
Change subject: soc/amd/cezanne: Add ACPI opregion to root complex
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/77682/comment/e4672abe_06c7d42b?usp... :
PS6, Line 63: Add ACPI device, opregion to host bridge needed for Windows ACP driver.
: *
: * This provides a mailbox interface for the ACP drivers to notify the PSP
: * that the DSP firmware has been loaded, so that the PSP can validate
: * the firmware and set the qualifier bit to enable running it.
is this comment still valid? or should we make it more generic?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77682?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d00c86647e51e5cae621fe788f0a1b06471a443
Gerrit-Change-Number: 77682
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 27 Feb 2025 23:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No